Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158433006: Store context options on caps. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@onecaps
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add file to git #

Patch Set 3 : fix other targets #

Patch Set 4 : fix issues? #

Patch Set 5 : remove case statement accidentally checked in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -79 lines) Patch
M bench/nanobench.cpp View 1 2 4 2 chunks +3 lines, -1 line 0 comments Download
M gyp/gpu.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrCaps.h View 4 chunks +11 lines, -1 line 0 comments Download
M include/gpu/GrContext.h View 5 chunks +5 lines, -21 lines 0 comments Download
A include/gpu/GrContextOptions.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/GrContextFactory.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuFactory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 3 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLContext.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 3 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/CopyTilesRenderer.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M tools/CopyTilesRenderer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.h View 1 2 9 chunks +9 lines, -8 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderingFlags.cpp View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 26 (13 generated)
bsalomon
Requires https://codereview.chromium.org/1153813002/ to land first
5 years, 7 months ago (2015-05-22 17:23:12 UTC) #2
joshualitt
On 2015/05/22 17:23:12, bsalomon wrote: > Requires https://codereview.chromium.org/1153813002/ to land first lgtm
5 years, 7 months ago (2015-05-22 18:12:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158433006/1
5 years, 7 months ago (2015-05-22 18:27:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/1229) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 7 months ago (2015-05-22 18:28:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158433006/20001
5 years, 7 months ago (2015-05-22 18:37:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/462) Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 7 months ago (2015-05-22 18:42:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158433006/40001
5 years, 7 months ago (2015-05-22 19:16:08 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/f28cff71db2cbb1ff18a8fbf1e80ca761d1f69bc
5 years, 7 months ago (2015-05-22 19:25:45 UTC) #16
bsalomon
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1151603005/ by bsalomon@google.com. ...
5 years, 7 months ago (2015-05-22 19:40:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158433006/60001
5 years, 7 months ago (2015-05-22 20:53:06 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1240)
5 years, 7 months ago (2015-05-22 20:54:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158433006/80001
5 years, 7 months ago (2015-05-22 20:55:39 UTC) #25
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 21:01:50 UTC) #26
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/682c269a1511200322916af83053e26004c0ec40

Powered by Google App Engine
This is Rietveld 408576698