LayoutTests/fast/dom/serialize-nodes.xhtml - Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/serialize-nodes.xhtml

Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/dom/serialize-nodes.xhtml

diff --git a/LayoutTests/fast/dom/serialize-nodes.xhtml b/LayoutTests/fast/dom/serialize-nodes.xhtml

index ae4791dc8b44d631b4556a66c9d2df4f65d34ee0..e9975bef22ae45e83eda51c2da4a851039a12fca 100644

--- a/LayoutTests/fast/dom/serialize-nodes.xhtml

+++ b/LayoutTests/fast/dom/serialize-nodes.xhtml

@@ -28,8 +28,7 @@ window.addEventListener("load", function() {

c.setAttributeNS("urn:foo-ns", "foo:name", "one");

c.setAttributeNS("urn:bar-ns", "bar:name", "two");

var attr = d.createAttributeNS(null, "name");

- var text = d.createTextNode("three");

- attr.appendChild(text);

+ attr.value = "three";

c.setAttributeNode(attr);

window.alert("foo:name is " + c.getAttributeNS("urn:foo-ns", "name") + " and should be one");