Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: LayoutTests/dom/html/level1/core/hc_attrsetvalue1.js

Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/dom/html/level1/core/hc_attrsetvalue1.js
diff --git a/LayoutTests/dom/html/level1/core/hc_attrsetvalue1.js b/LayoutTests/dom/html/level1/core/hc_attrsetvalue1.js
index cc28775a58c0697e0618410af09d8e231b676df3..f03ed5e95a6a7e337e52d8870dc80cd6480eef84 100644
--- a/LayoutTests/dom/html/level1/core/hc_attrsetvalue1.js
+++ b/LayoutTests/dom/html/level1/core/hc_attrsetvalue1.js
@@ -83,9 +83,6 @@ function hc_attrsetvalue1() {
var attributes;
var titleAttr;
var value;
- var retval;
- var firstChild;
- var otherChild;
var docRef = null;
if (typeof(this.doc) != 'undefined') {
@@ -97,28 +94,14 @@ function hc_attrsetvalue1() {
attributes = testNode.attributes;
titleAttr = attributes.getNamedItem("title");
- firstChild = titleAttr.firstChild;
- assertNotNull("attrChildNotNull",firstChild);
-titleAttr.value = "Tomorrow";
-
- firstChild.nodeValue = "impl reused node";
+ titleAttr.value = "Tomorrow";
value = titleAttr.value;
-
assertEquals("attrValue","Tomorrow",value);
- value = titleAttr.nodeValue;
+ value = titleAttr.nodeValue;
assertEquals("attrNodeValue","Tomorrow",value);
- firstChild = titleAttr.lastChild;
-
- value = firstChild.nodeValue;
-
- assertEquals("firstChildValue","Tomorrow",value);
- otherChild = firstChild.nextSibling;
-
- assertNull("nextSiblingIsNull",otherChild);
-
}
function runTest() {

Powered by Google App Engine
This is Rietveld 408576698