LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html - Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html

Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: address feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Attr/child-nodes-length-cache-expected.txt ('k') | LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue-expected.txt » ('j') | Source/core/dom/Attr.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html

diff --git a/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html b/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html

deleted file mode 100644

index 6c07c58c068ce4b2898f71269d3698021d20fe41..0000000000000000000000000000000000000000

--- a/LayoutTests/fast/dom/Attr/invalidate-nodelist-after-attr-setvalue.html

+++ /dev/null

@@ -1,29 +0,0 @@

-<!DOCTYPE html>

-<html>

-<body>

-<p>This tests setting the value of an attribute node after caching childNodes of the attribute node.<br>

-The cache should be cleared and childNodes[0].data should return the new value.<br>

-You should see PASS below:</p>

-<div id="console"></div>

-<script src="../../../resources/js-test.js"></script>

-<script>

-var element = document.createElement('div');

-var nameAttrNode = document.createAttribute('name');

-var oldValue = document.createTextNode('oldName');

-nameAttrNode.appendChild(oldValue);

-element.setAttributeNode(nameAttrNode);

-document.body.appendChild(element);

-shouldBe("nameAttrNode.childNodes.length", '1');

-shouldBe('nameAttrNode.childNodes[0]', 'oldValue');

-shouldBe('nameAttrNode.childNodes[0].data', '"oldName"');

-debug('');

-shouldBe("nameAttrNode.value = 'newName'; nameAttrNode.value", '"newName"');

-shouldNotBe("nameAttrNode.childNodes[0]", 'oldValue');

-shouldBe("nameAttrNode.childNodes[0].data", '"newName"');

-</script>

-</body>

-</html>