LayoutTests/svg/custom/image-with-attr-change-after-delete-crash.html - Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/custom/image-with-attr-change-after-delete-crash.html

Issue 1158433004: Remove Attr child nodes (making Attr a Node, not a ContainerNode) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/console/console-format-expected.txt ('k') | LayoutTests/svg/custom/image-with-attr-change-after-delete-crash-expected.txt » ('j') | Source/core/dom/Element.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/custom/image-with-attr-change-after-delete-crash.html

diff --git a/LayoutTests/svg/custom/image-with-attr-change-after-delete-crash.html b/LayoutTests/svg/custom/image-with-attr-change-after-delete-crash.html

index 228b4aedeae37d66599cf333771b7d24636ee2fc..7ae226a2e26b9945e559b45e4494fd012afbe6e6 100644

--- a/LayoutTests/svg/custom/image-with-attr-change-after-delete-crash.html

+++ b/LayoutTests/svg/custom/image-with-attr-change-after-delete-crash.html

@@ -22,7 +22,7 @@

setTimeout("crash()", 0);

function crash() {

- svgImage.attributes[5].replaceChild(newTextNode, svgImage.attributes[5].childNodes[0]);

+ svgImage.href.baseVal = "no-image";

davve 2015/05/28 14:32:14 Nit: may want to change href through .value to get

philipj_slow 2015/05/28 15:28:36 Done.

svgImage.parentNode.removeChild(svgImage);

delete svgImage;

forceGC();