Disable NPAPI support

Disable NPAPI support by removing the --enable-npapi switch, chrome://flags and enterprise policy override.

--enable-npapi-for-testing will remain temporarily until the rest of the NPAPI code and tests are removed.

This is a selective revert of 0539f2f5214fc17fdd5d1964be0ceedf98fdb9ce and 26d09db19381c2236a2890c045761465c78bc958.

BUG=493212, 489066
Committed: https://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c
Cr-Commit-Position: refs/heads/master@{#332006}

[Will Harris, 2015-05-28 18:04:41]

wfh@chromium.org changed reviewers:
+ jam@chromium.org

[Will Harris, 2015-05-28 18:05:17]

wfh@chromium.org changed reviewers:
+ bauerb@chromium.org, mnissler@chromium.org

[Will Harris, 2015-05-28 18:46:43]

PTAL

Changelist looks scary, but it's really just two reverts, leaving a few files in
place.

mnissler -> chrome/policy
bauerb -> *plugin*
jam -> everything else

Thanks!

[jam, 2015-05-28 19:22:38]

https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/content_...
File chrome/browser/content_settings/content_settings_browsertest.cc (right):

https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/content_...
chrome/browser/content_settings/content_settings_browsertest.cc:373:
command_line->AppendSwitch(switches::kEnableNpapiForTesting);
just delete these two tests

https://codereview.chromium.org/1158423003/diff/20001/content/browser/plugin_...
File content/browser/plugin_browsertest.cc (right):

https://codereview.chromium.org/1158423003/diff/20001/content/browser/plugin_...
content/browser/plugin_browsertest.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
just delete this whole file now

https://codereview.chromium.org/1158423003/diff/20001/content/public/common/c...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/1158423003/diff/20001/content/public/common/c...
content/public/common/content_switches.h:302: CONTENT_EXPORT extern const char
kEnableNpapiForTesting[];
i think you should just take this out now

[Will Harris, 2015-05-28 19:34:24]

On 2015/05/28 19:22:38, jam wrote:
>
https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/content_...
> File chrome/browser/content_settings/content_settings_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/content_...
> chrome/browser/content_settings/content_settings_browsertest.cc:373:
> command_line->AppendSwitch(switches::kEnableNpapiForTesting);
> just delete these two tests
> 
>
https://codereview.chromium.org/1158423003/diff/20001/content/browser/plugin_...
> File content/browser/plugin_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1158423003/diff/20001/content/browser/plugin_...
> content/browser/plugin_browsertest.cc:1: // Copyright (c) 2012 The Chromium
> Authors. All rights reserved.
> just delete this whole file now
> 
>
https://codereview.chromium.org/1158423003/diff/20001/content/public/common/c...
> File content/public/common/content_switches.h (right):
> 
>
https://codereview.chromium.org/1158423003/diff/20001/content/public/common/c...
> content/public/common/content_switches.h:302: CONTENT_EXPORT extern const char
> kEnableNpapiForTesting[];
> i think you should just take this out now

To keep the CLs manageable I'm splitting them up - see the CL description. I'll
be removing tests (there's more than just here in this CL) and the flag in a
series of follow ups.

[jam, 2015-05-28 19:59:35]

lgtm

[Will Harris, 2015-05-28 20:00:52]

On 2015/05/28 19:59:35, jam wrote:
> lgtm

Context as we spoke offline: the --enable-npapi-for-testing flag has to remain
because content_shell needs it for the webkit tests (which will be removed in a
later CL) so we agreed to leave all the test removal until a follow-up CL.

[Mattias Nissler (ping if slow), 2015-05-29 07:10:02]

policy changes LGTM after removing the stray declaration

https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/policy/c...
File chrome/browser/policy/chrome_browser_policy_connector.h (right):

https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/policy/c...
chrome/browser/policy/chrome_browser_policy_connector.h:43: void
AppendExtraFlagsPerPolicy();
Remove this

[Bernhard Bauer, 2015-05-29 09:24:03]

I don't think you need it from me, but LGTM.

[Will Harris, 2015-05-29 16:54:57]

thanks for the reviews.

https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/policy/c...
File chrome/browser/policy/chrome_browser_policy_connector.h (right):

https://codereview.chromium.org/1158423003/diff/20001/chrome/browser/policy/c...
chrome/browser/policy/chrome_browser_policy_connector.h:43: void
AppendExtraFlagsPerPolicy();
On 2015/05/29 07:10:02, Mattias Nissler wrote:
> Remove this

Done.

[Will Harris, 2015-05-29 16:55:01]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2015-05-29 16:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jam@chromium.org, mnissler@chromium.org
Link to the patchset: https://codereview.chromium.org/1158423003/#ps40001
(title: "remove unneeded function declaration")

[commit-bot: I haz the power, 2015-05-29 16:55:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158423003/40001

[commit-bot: I haz the power, 2015-05-29 17:56:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-29 17:57:36]

Patchset 3 (id:??) landed as
https://crrev.com/cfdd80f3d2a845a2267dd9ffe81011609f74eb0c
Cr-Commit-Position: refs/heads/master@{#332006}