Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: src/deoptimizer.cc

Issue 1158423002: Treat links that organize weak objects weakly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/contexts.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/cpu-profiler.h" 9 #include "src/cpu-profiler.h"
10 #include "src/deoptimizer.h" 10 #include "src/deoptimizer.h"
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 while (!element->IsUndefined()) { 253 while (!element->IsUndefined()) {
254 JSFunction* function = JSFunction::cast(element); 254 JSFunction* function = JSFunction::cast(element);
255 Object* next = function->next_function_link(); 255 Object* next = function->next_function_link();
256 if (function->code()->kind() != Code::OPTIMIZED_FUNCTION || 256 if (function->code()->kind() != Code::OPTIMIZED_FUNCTION ||
257 (visitor->VisitFunction(function), 257 (visitor->VisitFunction(function),
258 function->code()->kind() != Code::OPTIMIZED_FUNCTION)) { 258 function->code()->kind() != Code::OPTIMIZED_FUNCTION)) {
259 // The function no longer refers to optimized code, or the visitor 259 // The function no longer refers to optimized code, or the visitor
260 // changed the code to which it refers to no longer be optimized code. 260 // changed the code to which it refers to no longer be optimized code.
261 // Remove the function from this list. 261 // Remove the function from this list.
262 if (prev != NULL) { 262 if (prev != NULL) {
263 prev->set_next_function_link(next); 263 prev->set_next_function_link(next, UPDATE_WEAK_WRITE_BARRIER);
264 } else { 264 } else {
265 context->SetOptimizedFunctionsListHead(next); 265 context->SetOptimizedFunctionsListHead(next);
266 } 266 }
267 // The visitor should not alter the link directly. 267 // The visitor should not alter the link directly.
268 CHECK_EQ(function->next_function_link(), next); 268 CHECK_EQ(function->next_function_link(), next);
269 // Set the next function link to undefined to indicate it is no longer 269 // Set the next function link to undefined to indicate it is no longer
270 // in the optimized functions list. 270 // in the optimized functions list.
271 function->set_next_function_link(context->GetHeap()->undefined_value()); 271 function->set_next_function_link(context->GetHeap()->undefined_value(),
272 SKIP_WRITE_BARRIER);
272 } else { 273 } else {
273 // The visitor should not alter the link directly. 274 // The visitor should not alter the link directly.
274 CHECK_EQ(function->next_function_link(), next); 275 CHECK_EQ(function->next_function_link(), next);
275 // preserve this element. 276 // preserve this element.
276 prev = function; 277 prev = function;
277 } 278 }
278 element = next; 279 element = next;
279 } 280 }
280 281
281 visitor->LeaveContext(context); 282 visitor->LeaveContext(context);
(...skipping 3558 matching lines...) Expand 10 before | Expand all | Expand 10 after
3840 int raw_position = static_cast<int>(info->data()); 3841 int raw_position = static_cast<int>(info->data());
3841 last_position = raw_position ? SourcePosition::FromRaw(raw_position) 3842 last_position = raw_position ? SourcePosition::FromRaw(raw_position)
3842 : SourcePosition::Unknown(); 3843 : SourcePosition::Unknown();
3843 } else if (info->rmode() == RelocInfo::DEOPT_REASON) { 3844 } else if (info->rmode() == RelocInfo::DEOPT_REASON) {
3844 last_reason = static_cast<Deoptimizer::DeoptReason>(info->data()); 3845 last_reason = static_cast<Deoptimizer::DeoptReason>(info->data());
3845 } 3846 }
3846 } 3847 }
3847 return DeoptInfo(SourcePosition::Unknown(), NULL, Deoptimizer::kNoReason); 3848 return DeoptInfo(SourcePosition::Unknown(), NULL, Deoptimizer::kNoReason);
3848 } 3849 }
3849 } } // namespace v8::internal 3850 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/contexts.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698