Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1158343003: [turbofan] Disable optimization of dynamic lookup slots. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable optimization of dynamic lookup slots. Note that this essentially disables optimization of "with" as well. R=hablich@chromium.org BUG=chromium:491897, chromium:491018 LOG=N Committed: https://crrev.com/7a709875319be620b69010a9f09cbb56f02f0074 Cr-Commit-Position: refs/heads/master@{#28725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-01 11:05:33 UTC) #1
Michael Hablich
On 2015/06/01 11:05:33, Michael Starzinger wrote: lgtm
5 years, 6 months ago (2015-06-01 11:06:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158343003/1
5 years, 6 months ago (2015-06-01 11:07:42 UTC) #4
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-01 11:07:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 11:40:16 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 11:40:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a709875319be620b69010a9f09cbb56f02f0074
Cr-Commit-Position: refs/heads/master@{#28725}

Powered by Google App Engine
This is Rietveld 408576698