Tools/Scripts/webkitpy/layout_tests/port/driver.py - Issue 1158323009: Revert of Add an additional content_shell per worker for running virtual tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/driver.py

Issue 1158323009: Revert of Add an additional content_shell per worker for running virtual tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@virtual_reference_flags

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/port/driver.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/driver.py b/Tools/Scripts/webkitpy/layout_tests/port/driver.py

index b8199ae030c949e01b9d2e650630013e9ab47a54..832056a8b3cfc3521aa3871004da1f0977da2c14 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/driver.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/driver.py

@@ -143,10 +143,9 @@

def run_test(self, driver_input, stop_when_done):

"""Run a single test and return the results.

- Note that it is okay if a test times out or crashes. content_shell

- will be stopped when the test ends, and then restarted for the next

- test when this function is invoked again. As part of the restart, the

- state of Driver will be reset.

+ Note that it is okay if a test times out or crashes and leaves

+ the driver in an indeterminate state. The upper layers of the program

+ are responsible for cleaning up and ensuring things are okay.

Returns a DriverOutput object.

"""