Issue 1158323009: Revert of Add an additional content_shell per worker for running virtual tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1158323009: Revert of Add an additional content_shell per worker for running virtual tests. (Closed)

Created:
4 years, 11 months ago by leviw_travelin_and_unemployed

Modified:
4 years, 11 months ago

Reviewers:
joelo, ojan, jsbell, Dirk Pranke

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@virtual_reference_flags

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Add an additional content_shell per worker for running virtual tests. (patchset #5 id:80001 of https://codereview.chromium.org/1161863003/) Reason for revert: Causing issues on Android bots: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20(Nexus4) Original issue's description: > Add an additional content_shell per worker for running virtual tests. > > The secondary content_shell will only be used for rendering the virtual test's references, and only if the references use default flags. > > The secondary content_shell is lazily initialized and shutdown at the end of each test suite. > > BUG=471431 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196445 TBR=ojan@chromium.org,dpranke@chromium.org,jsbell@chromium.org,joelo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471431 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196533

Created: 4 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -60 lines)			Patch
M	Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py	View	9 chunks	+22 lines, -22 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	View	4 chunks	+5 lines, -18 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/driver.py	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/test.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

leviw_travelin_and_unemployed

Created Revert of Add an additional content_shell per worker for running virtual tests.

4 years, 11 months ago (2015-06-04 22:24:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158323009/1

4 years, 11 months ago (2015-06-04 22:25:18 UTC) #2

commit-bot: I haz the power

4 years, 11 months ago (2015-06-04 22:25:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196533