Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158323008: Expand the devtools/common readme. (Closed)

Created:
5 years, 6 months ago by ppi
Modified:
5 years, 6 months ago
Reviewers:
tonyg
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expand the devtools/common readme. Fixes domokit/devtools#1. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eaf6dddef106a7f46abf3b78db9362206e684e89

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Address Tony's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M mojo/devtools/common/README.md View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Tony, ptal.
5 years, 6 months ago (2015-06-04 17:26:17 UTC) #2
tonyg
lgtm thanks! https://codereview.chromium.org/1158323008/diff/20001/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1158323008/diff/20001/mojo/devtools/common/README.md#newcode9 mojo/devtools/common/README.md:9: apptest frameworks, and recommend dropping ", and" ...
5 years, 6 months ago (2015-06-04 17:33:20 UTC) #3
ppi
https://codereview.chromium.org/1158323008/diff/20001/mojo/devtools/common/README.md File mojo/devtools/common/README.md (right): https://codereview.chromium.org/1158323008/diff/20001/mojo/devtools/common/README.md#newcode9 mojo/devtools/common/README.md:9: apptest frameworks, and On 2015/06/04 17:33:20, tonyg wrote: > ...
5 years, 6 months ago (2015-06-04 17:37:00 UTC) #4
ppi
5 years, 6 months ago (2015-06-04 17:37:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
eaf6dddef106a7f46abf3b78db9362206e684e89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698