Include 'outline' in LayoutSVGBlock::visualOverflowRect

Source/core/layout/svg/LayoutSVGText.cpp

 /*
  * Copyright (C) 2006 Apple Computer, Inc.
  * Copyright (C) 2006 Alexander Kellett <lypanov@kde.org>
  * Copyright (C) 2006 Oliver Hunt <ojh16@student.canterbury.ac.nz>
  * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
  * Copyright (C) 2012 Google Inc.
  *
@@ skipping 351 matching lines @@
     checkLayoutAttributesConsistency(this, m_layoutAttributes);
 
     // Reduced version of LayoutBlock::layoutBlock(), which only takes care of SVG text.
     // All if branches that could cause early exit in LayoutBlocks layoutBlock() method are turned into assertions.
     ASSERT(!isInline());
     ASSERT(!simplifiedLayout());
     ASSERT(!scrollsOverflow());
     ASSERT(!hasControlClip());
     ASSERT(!hasColumns());
     ASSERT(!positionedObjects());
-    ASSERT(!m_overflow);
     ASSERT(!isAnonymousBlock());
 
     if (!firstChild())
         setChildrenInline(true);
 
     // FIXME: We need to find a way to only layout the child boxes, if needed.
     FloatRect oldBoundaries = objectBoundingBox();
     ASSERT(childrenInline());
 
     rebuildFloatsFromIntruding();
 
     LayoutUnit beforeEdge = borderBefore() + paddingBefore();
     LayoutUnit afterEdge = borderAfter() + paddingAfter() + scrollbarLogicalHeight();
     setLogicalHeight(beforeEdge);
 
     LayoutState state(*this, locationOffset());
     LayoutUnit paintInvalidationLogicalTop = 0;
     LayoutUnit paintInvalidationLogicalBottom = 0;
     layoutInlineChildren(true, paintInvalidationLogicalTop, paintInvalidationLogicalBottom, afterEdge);
 
     if (m_needsReordering)
         m_needsReordering = false;
 
     // If we don't have any line boxes, then make sure the frame rect is still cleared.
     if (!firstLineBox())
         setFrameRect(LayoutRect());
 
+    m_overflow.clear();
+    addVisualEffectOverflow();

[chrishtr, 2015/06/04 16:57:03]

So now LayoutSVGBlock inherits behavior from LayoutBlockFlow and gets its
overflow from there?

[fs, 2015/06/05 09:01:47]

If the derived class does not override that in any way - yes. LayoutSVGText
overrides this (does not call parent-class layout), while LayoutSVGForeignObject
doesn't override (and did update m_overflow before, but didn't use it in
visualOverflowRect - which might seem a bit odd.)

+
     if (!updateCachedBoundariesInParents)
         updateCachedBoundariesInParents = oldBoundaries != objectBoundingBox();
 
     // Invalidate all resources of this client if our layout changed.
     if (everHadLayout() && selfNeedsLayout())
         SVGResourcesCache::clientLayoutChanged(this);
 
     // If our bounds changed, notify the parents.
     if (updateCachedBoundariesInParents)
         LayoutSVGBlock::setNeedsBoundariesUpdate();
@@ skipping 95 matching lines @@
     SVGResourcesCache::clientWillBeRemovedFromTree(child);
 
     Vector<SVGTextLayoutAttributes*, 2> affectedAttributes;
     FontCachePurgePreventer fontCachePurgePreventer;
     subtreeChildWillBeRemoved(child, affectedAttributes);
     LayoutSVGBlock::removeChild(child);
     subtreeChildWasRemoved(affectedAttributes);
 }
 
 }