Remove the virtual ThemePainter::paintMediaCastButton()

Remove the virtual ThemePainter::paintMediaCastButton()

It appears to be an indirection without purpose.

ThemePainterMac does not inherit from ThemePainterDefault, so on Mac the
default implementation of painting nothing was used. If cast was made to
work for Mac the button would fail to paint, so rebaseline the tests.

BUG=493880
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196174

[philipj_slow, 2015-05-28 11:01:18]

philipj@opera.com changed reviewers:
+ fs@opera.com

[philipj_slow, 2015-05-28 11:01:19]

PTAL

[fs, 2015-05-28 11:08:05]

lgtm

Don't know if they intended to have different Cast buttons on different
platforms - seems a bit unlikely (given that we have the overlay bits etc
already), so probably not. And if so I'm sure we'll hear about it ;-)

[philipj_slow, 2015-05-28 11:15:33]

philipj@opera.com changed reviewers:
+ aberent@chromium.org

[philipj_slow, 2015-05-28 11:15:33]

aberent@, can you confirm that there's nothing funky going on here that isn't in
the public repo?

[aberent, 2015-05-28 11:31:39]

On 2015/05/28 11:15:33, philipj_UTC2 wrote:
> aberent@, can you confirm that there's nothing funky going on here that isn't
in
> the public repo?

lgtm. No, there is nothing private anywhere near here (or anywhere in the
renderer code for Cast). I am sure I had a reason for this originally (maybe
simply copying what was done for some other button), but the extra level now
makes no sense to me.

BTW almost all of Cast is now public, in the Chromium repository (although I
still need to upstream the tests). On Andoid you can now cast from
ChromeShell.apk, or ChromePublic.apk, not just from Chrome

[philipj_slow, 2015-05-29 08:23:43]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-05-29 08:23:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158323004/1

[commit-bot: I haz the power, 2015-05-29 11:26:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-29 11:26:50]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/56868)

[philipj_slow, 2015-05-29 12:32:52]

OK, so the tests for the cast button for Mac are now failing. ThemePainterMac
does not inherit from ThemePainterDefault, so on Mac the default implementation
of painting nothing was used. This seems wrong, because if cast was made to work
for Mac it would be weird to fail to paint the button because of this. I'll
update the test expectations and try again.

[philipj_slow, 2015-05-29 21:28:54]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-05-29 21:28:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
aberent@chromium.org, fs@opera.com
Link to the patchset: https://codereview.chromium.org/1158323004/#ps20001
(title: "rebaseline")

[commit-bot: I haz the power, 2015-05-29 21:29:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158323004/20001

[commit-bot: I haz the power, 2015-05-29 22:46:07]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196174