Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1158323002: Revert of Build a basic Mojo service framework for device/usb (Closed)

Created:
5 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build a basic Mojo service framework for device/usb (patchset #4 id:60001 of https://codereview.chromium.org/1155163008/) Reason for revert: Broken Win8 GN build http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/6609 Original issue's description: > Build a basic Mojo service framework for device/usb > > BUG=492805 > R=reillyg@chromium.org > > Committed: https://crrev.com/249cc25c5e0a2e338cd3efec6e1a3964e7c983e9 > Cr-Commit-Position: refs/heads/master@{#331707} TBR=reillyg@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492805 Committed: https://crrev.com/c710e9810205d15f4fe4db480cf4acbcd5a8462b Cr-Commit-Position: refs/heads/master@{#331709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -970 lines) Patch
M chrome/browser/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_device_client.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/chrome_device_client.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M device/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M device/core/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M device/core/core.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M device/core/device_client.h View 2 chunks +1 line, -11 lines 0 comments Download
M device/core/device_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M device/usb/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
D device/usb/device_impl.h View 1 chunk +0 lines, -44 lines 0 comments Download
D device/usb/device_impl.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D device/usb/device_impl_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D device/usb/device_manager_impl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D device/usb/device_manager_impl.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D device/usb/device_manager_impl_unittest.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D device/usb/public/cpp/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D device/usb/public/cpp/device_manager_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
D device/usb/public/cpp/device_manager_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D device/usb/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D device/usb/public/interfaces/device.mojom View 1 chunk +0 lines, -61 lines 0 comments Download
D device/usb/public/interfaces/device_manager.mojom View 1 chunk +0 lines, -38 lines 0 comments Download
D device/usb/type_converters.h View 1 chunk +0 lines, -83 lines 0 comments Download
D device/usb/type_converters.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M device/usb/usb.gyp View 2 chunks +0 lines, -32 lines 0 comments Download
M extensions/shell/browser/shell_device_client.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of Build a basic Mojo service framework for device/usb
5 years, 6 months ago (2015-05-28 00:56:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158323002/1
5 years, 6 months ago (2015-05-28 00:57:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 00:59:20 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 01:00:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c710e9810205d15f4fe4db480cf4acbcd5a8462b
Cr-Commit-Position: refs/heads/master@{#331709}

Powered by Google App Engine
This is Rietveld 408576698