Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1158273011: [turbofan] Turn JSBuiltinReducer into an AdvancedReducer. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn JSBuiltinReducer into an AdvancedReducer. This in turn allows usage of AdvancedReducer::ReplaceWithValue which has access to the underlying graph reducer. It will allow us to deal with exception continuations correctly. R=titzer@chromium.org Committed: https://crrev.com/a6f23850a5106931c4e73e8ce0f339ec917b36a5 Cr-Commit-Position: refs/heads/master@{#28813}

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-05 12:01:52 UTC) #3
titzer
lgtm https://codereview.chromium.org/1158273011/diff/60001/test/unittests/compiler/js-builtin-reducer-unittest.cc File test/unittests/compiler/js-builtin-reducer-unittest.cc (right): https://codereview.chromium.org/1158273011/diff/60001/test/unittests/compiler/js-builtin-reducer-unittest.cc#newcode29 test/unittests/compiler/js-builtin-reducer-unittest.cc:29: // TODO(titzer): mock the GraphReducer here for better ...
5 years, 6 months ago (2015-06-05 12:30:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158273011/60001
5 years, 6 months ago (2015-06-05 12:36:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 6 months ago (2015-06-05 12:37:52 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:37:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6f23850a5106931c4e73e8ce0f339ec917b36a5
Cr-Commit-Position: refs/heads/master@{#28813}

Powered by Google App Engine
This is Rietveld 408576698