Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158273007: switch bitmapshader internals over to pixmap (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

switch bitmapshader internals over to pixmap BUG=skia: NOTRY=True Committed: https://skia.googlesource.com/skia/+/ad7ae6c821c530dd6cb54b0e8931ba8b10e8d87d

Patch Set 1 #

Patch Set 2 : fix neon/mips to use pixmpas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -182 lines) Patch
M include/core/SkPixmap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBitmapController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapController.cpp View 6 chunks +22 lines, -15 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 4 chunks +9 lines, -13 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcState.cpp View 21 chunks +32 lines, -31 lines 0 comments Download
M src/core/SkBitmapProcState_matrix.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcState_matrixProcs.cpp View 6 chunks +15 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcState_matrix_template.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcState_procs.h View 16 chunks +22 lines, -22 lines 0 comments Download
M src/core/SkBitmapProcState_sample.h View 5 chunks +17 lines, -17 lines 0 comments Download
M src/core/SkBitmapProcState_shaderproc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/opts/SkBitmapProcState_matrix_neon.h View 1 8 chunks +18 lines, -13 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSE2.cpp View 8 chunks +18 lines, -18 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 1 3 chunks +11 lines, -12 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_mips_dsp.cpp View 1 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158273007/1
5 years, 6 months ago (2015-06-04 19:04:55 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/1392)
5 years, 6 months ago (2015-06-04 19:06:46 UTC) #4
reed1
5 years, 6 months ago (2015-06-04 19:37:11 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158273007/20001
5 years, 6 months ago (2015-06-04 19:37:12 UTC) #8
scroggo
lgtm
5 years, 6 months ago (2015-06-04 20:12:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158273007/20001
5 years, 6 months ago (2015-06-04 20:17:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158273007/20001
5 years, 6 months ago (2015-06-04 20:56:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158273007/20001
5 years, 6 months ago (2015-06-04 21:11:22 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 21:12:30 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ad7ae6c821c530dd6cb54b0e8931ba8b10e8d87d

Powered by Google App Engine
This is Rietveld 408576698