Issue 1158263005: Rename "BorderSide.None" to "BorderSide.none", since it's a constant, and change the sky.Size.infin…

Issue 1158263005: Rename "BorderSide.None" to "BorderSide.none", since it's a constant, and change the sky.Size.infin… (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
Chinmay, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Rename "BorderSide.None" to "BorderSide.none", since it's a constant, and change the sky.Size.infinite() constructor to a constant. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/462d230c498bc8c5d40f9f892e9ccd36940d14a1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	sky/engine/core/painting/Size.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/examples/game/lib/sprite_box.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/examples/raw/ink_well.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/raw/touch_demo.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/drawer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/scaffold.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/stack.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/tests/raw/render_flex.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Hixie

Committed patchset #1 (id:1) manually as 462d230c498bc8c5d40f9f892e9ccd36940d14a1 (presubmit successful).

5 years, 6 months ago (2015-06-04 23:17:25 UTC) #3

Message was sent while issue was closed.

lgtm