Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1158233004: Sync the AnimationEvent and TransitionEvent interfaces with the specs (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
CC:
darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, rjwright, shans, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the AnimationEvent and TransitionEvent interfaces with the specs http://dev.w3.org/csswg/css-animations/#interface-animationevent http://dev.w3.org/csswg/css-transitions/#transition-events With the default values in the AnimationEventInit dictionary, it's no longer necessary to check them in the C++ constructor. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196582

Patch Set 1 #

Patch Set 2 : TransitionEvent too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M Source/core/events/AnimationEvent.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/events/AnimationEvent.idl View 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/events/AnimationEventInit.idl View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/events/TransitionEvent.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/TransitionEventInit.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
PTAL. The double->float TODO honestly doesn't seem sensible to me, do you think we should ...
5 years, 6 months ago (2015-06-03 18:41:00 UTC) #2
alancutter (OOO until 2018)
Can AnimationEventInit::m_elapsedTime be a double now instead of Nullable<double>? +dstockwell +shans for review and spec ...
5 years, 6 months ago (2015-06-05 03:37:42 UTC) #4
dstockwell
On 2015/06/05 at 03:37:42, alancutter wrote: > Can AnimationEventInit::m_elapsedTime be a double now instead of ...
5 years, 6 months ago (2015-06-05 06:27:57 UTC) #5
philipj_slow
On 2015/06/05 03:37:42, alancutter wrote: > Can AnimationEventInit::m_elapsedTime be a double now instead of > ...
5 years, 6 months ago (2015-06-05 13:21:37 UTC) #6
philipj_slow
On 2015/06/05 06:27:57, dstockwell wrote: > I'm not sure why elapsedTime should be a float, ...
5 years, 6 months ago (2015-06-05 13:23:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158233004/20001
5 years, 6 months ago (2015-06-05 13:24:14 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 15:53:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196582

Powered by Google App Engine
This is Rietveld 408576698