[iOS] Add FakeSyncService and factory for testing

[iOS] Add FakeSyncService and factory for testing

Committed: https://crrev.com/1178c2b900d5ac2176c3ac3b1248df1620c07bf7
Cr-Commit-Position: refs/heads/master@{#333727}

[droger, 2015-06-08 16:11:08]

droger@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2015-06-08 16:24:17]

lgtm with nits and comment

https://codereview.chromium.org/1158223003/diff/10009/ios/public/test/fake_sy...
File ios/public/test/fake_sync_service.h (right):

https://codereview.chromium.org/1158223003/diff/10009/ios/public/test/fake_sy...
ios/public/test/fake_sync_service.h:14: class FakeSyncService : public
sync_driver::SyncService, public KeyedService {
Could you get this moved into //components/sync_driver? I think it would make
sense to have the fake implementation living there. If it cannot be a
KeyedService then at least you can use a small wrapper in the
FakeSyncServiceFactory, something like:

class FakeSyncServiceWrapper : public KeyedService {
 public:
  FakeSyncServiceWrapper() {}
  sync_driver::SyncService* sync_service() {
    return &fake_sync_service_;
  }
 private:
  FakeSyncService fake_sync_service_;
};

// static
sync_driver::SyncService* FakeSyncServiceFactory::GetForInstance(
    web::BrowserState* browser_state) {
  return static_cast<FakeSyncServiceWrapper*>(
      GetInstance()->GetServiceForBrowserState(
          browser_state, true))->sync_service();
}

I'm fine if this is done in a followup CL with a tracking crbug.

https://codereview.chromium.org/1158223003/diff/10009/ios/public/test/test_ke...
File ios/public/test/test_keyed_service_provider.cc (right):

https://codereview.chromium.org/1158223003/diff/10009/ios/public/test/test_ke...
ios/public/test/test_keyed_service_provider.cc:15: class FakeSyncServiceFactory
: public BrowserStateKeyedServiceFactory {
nit: move this to fake_sync_service_factory.{h,cc}

https://codereview.chromium.org/1158223003/diff/10009/ios/public/test/test_ke...
ios/public/test/test_keyed_service_provider.cc:23: static FakeSyncService*
GetForBrowserState(web::BrowserState* browser_state) {
nit: s/FakeSyncService*/sync_driver::SyncService*/

[droger, 2015-06-09 09:03:33]

Patchset #3 (id:30001) has been deleted

[droger, 2015-06-09 09:06:16]

droger@chromium.org changed reviewers:
+ zea@chromium.org

[droger, 2015-06-09 09:06:17]

I moved FakeSyncService to //components/sync_driver.

+zea for components/sync_driver

[Nicolas Zea, 2015-06-09 21:27:20]

sync LGTM

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
File components/sync_driver/fake_sync_service.cc (right):

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
components/sync_driver/fake_sync_service.cc:7: #include
"components/sync_driver/data_type_manager.h"
is this necessary?

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
File components/sync_driver/fake_sync_service.h (right):

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
components/sync_driver/fake_sync_service.h:8: #include
"components/sync_driver/fake_sync_service.h"
Remove?

[droger, 2015-06-10 09:31:55]

droger@chromium.org changed reviewers:
+ rogerta@chromium.org

[droger, 2015-06-10 09:31:56]

+rogerta for the new dependency of sync_driver on google_apis. This dependency
is actually not new (GoogleServiceAuthError was already forward-declared) and
was missing in DEPS.

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
File components/sync_driver/fake_sync_service.cc (right):

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
components/sync_driver/fake_sync_service.cc:7: #include
"components/sync_driver/data_type_manager.h"
On 2015/06/09 21:27:20, Nicolas Zea wrote:
> is this necessary?

Removed.

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
File components/sync_driver/fake_sync_service.h (right):

https://codereview.chromium.org/1158223003/diff/70001/components/sync_driver/...
components/sync_driver/fake_sync_service.h:8: #include
"components/sync_driver/fake_sync_service.h"
On 2015/06/09 21:27:20, Nicolas Zea wrote:
> Remove?

Done.

[Roger Tawa OOO till Jul 10th, 2015-06-10 12:58:29]

Lgtm Google APIs deps

[droger, 2015-06-10 13:02:16]

Thanks for the reviews.

[droger, 2015-06-10 13:02:22]

The CQ bit was checked by droger@chromium.org

[droger, 2015-06-10 13:02:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1158223003/#ps90001
(title: "Review comments")

[commit-bot: I haz the power, 2015-06-10 13:02:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158223003/90001

[commit-bot: I haz the power, 2015-06-10 13:05:40]

Committed patchset #5 (id:90001)

[commit-bot: I haz the power, 2015-06-10 13:06:31]

Patchset 5 (id:??) landed as
https://crrev.com/1178c2b900d5ac2176c3ac3b1248df1620c07bf7
Cr-Commit-Position: refs/heads/master@{#333727}