Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1158213002: enable reordering (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

enable reordering NO_MERGE_BUILDS BUG=skia: Committed: https://skia.googlesource.com/skia/+/e932a6466b32c8e95ee680eafd685cf34428d393

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/GrInOrderDrawBuffer.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
5 years, 7 months ago (2015-05-27 16:03:31 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1158213002/diff/1/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (left): https://codereview.chromium.org/1158213002/diff/1/src/gpu/GrInOrderDrawBuffer.cpp#oldcode12 src/gpu/GrInOrderDrawBuffer.cpp:12: , fCommands(GrCommandBuilder::Create(context->getGpu(), false)) maybe put this in a ...
5 years, 7 months ago (2015-05-27 16:09:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158213002/20001
5 years, 7 months ago (2015-05-27 16:14:55 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 16:20:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e932a6466b32c8e95ee680eafd685cf34428d393

Powered by Google App Engine
This is Rietveld 408576698