Include overflows from visual effects in LayoutTableSection.

Include overflows from visual effects in LayoutTableSection.

In particular, include outlines. Previously they were not included. Not including
visual overflow effects results in incorrect paint invalidation (as exhibited by
the attached test), and also incorrect paint when Slimming Paint is active, since
the cull rect for painting such objecs is the visual overflow rect.

BUG=495368
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196609

[chrishtr, 2015-06-02 00:50:23]

chrishtr@chromium.org changed reviewers:
+ eae@chromium.org, leviw@chromium.org

[eae, 2015-06-02 01:56:14]

Change LGTM but I'd like to see the CL description updated to explain why this
matters.

[chrishtr, 2015-06-02 16:07:23]

Updated description.

[eae, 2015-06-02 16:54:02]

Much better, thank you!

[eae, 2015-06-02 16:54:07]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2015-06-02 16:54:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158193011/20001

[leviw_travelin_and_unemployed, 2015-06-02 17:51:11]

https://codereview.chromium.org/1158193011/diff/20001/LayoutTests/paint/table...
File LayoutTests/paint/tables/table-section-visual-overflow.html (right):

https://codereview.chromium.org/1158193011/diff/20001/LayoutTests/paint/table...
LayoutTests/paint/tables/table-section-visual-overflow.html:38: //
window.enablePixelTesting = true;
Leftover comment?

[leviw_travelin_and_unemployed, 2015-06-02 17:51:21]

The CQ bit was unchecked by leviw@chromium.org

[mstensho (USE GERRIT), 2015-06-03 10:32:29]

mstensho@opera.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2015-06-03 10:32:29]

Maybe also wrap the lines in the commit comment?

[chrishtr, 2015-06-05 19:46:28]

On 2015/06/02 at 17:51:11, leviw wrote:
>
https://codereview.chromium.org/1158193011/diff/20001/LayoutTests/paint/table...
> File LayoutTests/paint/tables/table-section-visual-overflow.html (right):
> 
>
https://codereview.chromium.org/1158193011/diff/20001/LayoutTests/paint/table...
> LayoutTests/paint/tables/table-section-visual-overflow.html:38: //
window.enablePixelTesting = true;
> Leftover comment?

Fixed.

[chrishtr, 2015-06-05 19:59:12]

On 2015/06/05 at 19:46:28, chrishtr wrote:
> On 2015/06/02 at 17:51:11, leviw wrote:
> >
https://codereview.chromium.org/1158193011/diff/20001/LayoutTests/paint/table...
> > File LayoutTests/paint/tables/table-section-visual-overflow.html (right):
> > 
> >
https://codereview.chromium.org/1158193011/diff/20001/LayoutTests/paint/table...
> > LayoutTests/paint/tables/table-section-visual-overflow.html:38: //
window.enablePixelTesting = true;
> > Leftover comment?
> 
> Fixed.

Re-added actually. Need pixel output to compare with the reference HTML.

[chrishtr, 2015-06-05 19:59:17]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-05 19:59:18]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1158193011/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-06-05 19:59:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158193011/60001

[commit-bot: I haz the power, 2015-06-05 22:59:51]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196609