Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2520)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 1158193008: Eliminate Modifier.TYPEDEF and deprecate ClassElement.isTypedef. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index df5d9ac1cdcc4bd660d0872d3102c5da97acbbea..a56496f6ff1c35705d35a634487c4806c6787c70 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -4,8 +4,8 @@
library engine.resolver;
-import "dart:math" as math;
import 'dart:collection';
+import "dart:math" as math;
import 'package:analyzer/src/generated/utilities_collection.dart';
@@ -2503,7 +2503,6 @@ class ElementBuilder extends RecursiveAstVisitor<Object> {
ClassElementImpl element = new ClassElementImpl.forNode(className);
element.abstract = node.abstractKeyword != null;
element.mixinApplication = true;
- element.typedef = true;
List<TypeParameterElement> typeParameters = holder.typeParameters;
element.typeParameters = typeParameters;
List<DartType> typeArguments = _createTypeParameterTypes(typeParameters);
@@ -5158,7 +5157,7 @@ class ImplicitConstructorBuilder extends SimpleElementVisitor {
@override
void visitClassElement(ClassElement classElement) {
(classElement as ClassElementImpl).mixinErrorsReported = false;
- if (classElement.isTypedef) {
+ if (classElement.isMixinApplication) {
_visitClassTypeAlias(classElement);
} else {
_visitClassDeclaration(classElement);
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | pkg/analyzer/lib/src/generated/testing/element_factory.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698