Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: net/socket/ssl_client_socket_pool.cc

Issue 1158193006: Converted bare pointer to scoped_ptr<> in net/socket and net/http (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_pool.cc
diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc
index f8db1d0504136d3f25863816e834ccc01bdd81f8..671501402b950a43ece6c94e55d424645fdc9431 100644
--- a/net/socket/ssl_client_socket_pool.cc
+++ b/net/socket/ssl_client_socket_pool.cc
@@ -617,11 +617,12 @@ LoadState SSLClientSocketPool::GetLoadState(
return base_.GetLoadState(group_name, handle);
}
-base::DictionaryValue* SSLClientSocketPool::GetInfoAsValue(
+scoped_ptr<base::DictionaryValue> SSLClientSocketPool::GetInfoAsValue(
const std::string& name,
const std::string& type,
bool include_nested_pools) const {
- base::DictionaryValue* dict = base_.GetInfoAsValue(name, type);
+ scoped_ptr<base::DictionaryValue>
+ dict(base_.GetInfoAsValue(name, type).Pass());
eroman 2015/06/01 17:07:23 No need for Pass
if (include_nested_pools) {
base::ListValue* list = new base::ListValue();
if (transport_pool_) {
@@ -641,7 +642,7 @@ base::DictionaryValue* SSLClientSocketPool::GetInfoAsValue(
}
dict->Set("nested_pools", list);
}
- return dict;
+ return dict.Pass();
}
base::TimeDelta SSLClientSocketPool::ConnectionTimeout() const {

Powered by Google App Engine
This is Rietveld 408576698