Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: net/socket/socks_client_socket_pool.cc

Issue 1158193006: Converted bare pointer to scoped_ptr<> in net/socket and net/http (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/socks_client_socket_pool.cc
diff --git a/net/socket/socks_client_socket_pool.cc b/net/socket/socks_client_socket_pool.cc
index b57a04ba1feb25c5e9d24d1e48bc5ca65865718c..d9e0d326598790c8b49d3228d531a85acb54ac5b 100644
--- a/net/socket/socks_client_socket_pool.cc
+++ b/net/socket/socks_client_socket_pool.cc
@@ -266,11 +266,12 @@ LoadState SOCKSClientSocketPool::GetLoadState(
return base_.GetLoadState(group_name, handle);
}
-base::DictionaryValue* SOCKSClientSocketPool::GetInfoAsValue(
+scoped_ptr<base::DictionaryValue> SOCKSClientSocketPool::GetInfoAsValue(
const std::string& name,
const std::string& type,
bool include_nested_pools) const {
- base::DictionaryValue* dict = base_.GetInfoAsValue(name, type);
+ scoped_ptr<base::DictionaryValue>
+ dict(base_.GetInfoAsValue(name, type).Pass());
eroman 2015/06/01 17:07:23 No need for Pass()
if (include_nested_pools) {
scoped_ptr<base::ListValue> list(new base::ListValue());
list->Append(transport_pool_->GetInfoAsValue("transport_socket_pool",
@@ -278,7 +279,7 @@ base::DictionaryValue* SOCKSClientSocketPool::GetInfoAsValue(
false));
dict->Set("nested_pools", list.Pass());
}
- return dict;
+ return dict.Pass();
}
base::TimeDelta SOCKSClientSocketPool::ConnectionTimeout() const {

Powered by Google App Engine
This is Rietveld 408576698