Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1158193004: Revert of Re-enable on-heap typed array allocation (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Re-enable on-heap typed array allocation (patchset #1 id:1 of https://codereview.chromium.org/1166433004/) Reason for revert: Win32 breakage Original issue's description: > Re-enable on-heap typed array allocation > > BUG=v8:3996 > R=mstarzinger@chromium.org > LOG=y > > Committed: https://crrev.com/f91df1f25dec4f1982c40af6118da8b699777475 > Cr-Commit-Position: refs/heads/master@{#28722} TBR=mstarzinger@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Committed: https://crrev.com/3be8651fccba6479908df22a32a2adff2c49a1f4 Cr-Commit-Position: refs/heads/master@{#28723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M src/hydrogen.cc View 2 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of Re-enable on-heap typed array allocation
5 years, 6 months ago (2015-06-01 10:58:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158193004/1
5 years, 6 months ago (2015-06-01 10:58:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 10:58:58 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 10:59:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3be8651fccba6479908df22a32a2adff2c49a1f4
Cr-Commit-Position: refs/heads/master@{#28723}

Powered by Google App Engine
This is Rietveld 408576698