Remove the old multicol implementation.

Remove the old multicol implementation.

Remove the RegionBasedColumns runtime flag. It has been enabled for everyone
for some time now, meaning that the old multicol implementation hasn't been
available since.

This CL mainly removes the ColumnInfo class and the LayoutObject::hasColumns()
method, and everything that depended on those.

BUG=408123
R=dsinclair@chromium.org,jchaffraix@chromium.org,leviw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196477

[mstensho (USE GERRIT), 2015-06-03 13:34:26]

There's more cleaning up to do here: Block continuation support can be removed,
since that's only used by the old multicol code. But I thought this CL was
already big enough. Please take a look.

[dsinclair, 2015-06-03 13:52:58]

https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
Source/core/paint/BoxPainter.cpp:77: LayoutRect
result(layoutView->unscaledDocumentRect());
This change seems unrelated?

[mstensho (USE GERRIT), 2015-06-03 13:56:22]

https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
Source/core/paint/BoxPainter.cpp:77: LayoutRect
result(layoutView->unscaledDocumentRect());
On 2015/06/03 13:52:58, dsinclair wrote:
> This change seems unrelated?

I killed LayoutView::backgroundRect(), because it no longer did anything unique,
because of the removal of the old multicol code. Should I put it back?

[dsinclair, 2015-06-03 13:59:45]

On 2015/06/03 at 13:56:22, mstensho wrote:
>
https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
> File Source/core/paint/BoxPainter.cpp (right):
> 
>
https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
> Source/core/paint/BoxPainter.cpp:77: LayoutRect
result(layoutView->unscaledDocumentRect());
> On 2015/06/03 13:52:58, dsinclair wrote:
> > This change seems unrelated?
> 
> I killed LayoutView::backgroundRect(), because it no longer did anything
unique, because of the removal of the old multicol code. Should I put it back?


I think it would be a good one to keep. LayoutView::backgroundRect() tells me
more then unscaledDocumentRect() by reading the name.

[mstensho (USE GERRIT), 2015-06-03 14:05:41]

On 2015/06/03 13:59:45, dsinclair wrote:
> On 2015/06/03 at 13:56:22, mstensho wrote:
> >
>
https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
> > File Source/core/paint/BoxPainter.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
> > Source/core/paint/BoxPainter.cpp:77: LayoutRect
> result(layoutView->unscaledDocumentRect());
> > On 2015/06/03 13:52:58, dsinclair wrote:
> > > This change seems unrelated?
> > 
> > I killed LayoutView::backgroundRect(), because it no longer did anything
> unique, because of the removal of the old multicol code. Should I put it back?
> 
> 
> I think it would be a good one to keep. LayoutView::backgroundRect() tells me
> more then unscaledDocumentRect() by reading the name.

OK, I'll keep it then.

[mstensho (USE GERRIT), 2015-06-03 14:05:52]

https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
File Source/core/paint/BoxPainter.cpp (right):

https://codereview.chromium.org/1158183006/diff/1/Source/core/paint/BoxPainte...
Source/core/paint/BoxPainter.cpp:77: LayoutRect
result(layoutView->unscaledDocumentRect());
On 2015/06/03 13:56:21, mstensho wrote:
> On 2015/06/03 13:52:58, dsinclair wrote:
> > This change seems unrelated?
> 
> I killed LayoutView::backgroundRect(), because it no longer did anything
unique,
> because of the removal of the old multicol code. Should I put it back?

Done.

[dsinclair, 2015-06-03 14:08:13]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2015-06-03 14:08:14]

lgtm

[commit-bot: I haz the power, 2015-06-03 14:08:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158183006/20001

[commit-bot: I haz the power, 2015-06-03 14:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 14:15:03]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[mstensho (USE GERRIT), 2015-06-03 14:16:48]

On 2015/06/03 14:15:03, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   blink_presubmit on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

Need an owner of Source/platform to ok this as well. jchaffraix, leviw?

[chrishtr, 2015-06-03 17:14:53]

chrishtr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2015-06-03 17:14:54]

lgtm

[chrishtr, 2015-06-03 17:15:02]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-03 17:15:03]

lgtm

[commit-bot: I haz the power, 2015-06-03 17:16:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158183006/20001

[commit-bot: I haz the power, 2015-06-03 21:31:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 21:31:51]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65081)

[mstensho (USE GERRIT), 2015-06-03 21:50:09]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-06-03 21:50:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158183006/20001

[commit-bot: I haz the power, 2015-06-03 22:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 22:48:32]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/65139)

[mstensho (USE GERRIT), 2015-06-04 04:27:30]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-06-04 04:27:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158183006/20001

[commit-bot: I haz the power, 2015-06-04 04:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 04:36:17]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[mstensho (USE GERRIT), 2015-06-04 06:16:14]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2015-06-04 06:16:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org, chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1158183006/#ps40001
(title: "rebase master")

[commit-bot: I haz the power, 2015-06-04 06:16:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158183006/40001

[commit-bot: I haz the power, 2015-06-04 08:04:14]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196477

[ojan, 2015-06-16 05:29:25]

This is so great!

\o/