Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1158183002: [turbofan] Optimize variable loads in DYNAMIC_GLOBAL mode. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize variable loads in DYNAMIC_GLOBAL mode. This adds a mechanism to the AstGraphBuilder which allows us to build optimized graphs that respect VariableMode hints for variables bound to Variable::LOOKUP locations. So far we only use the DYNAMIC_GLOBAL mode for variable loads. R=bmeurer@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments and small cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -45 lines) Patch
M src/compiler/ast-graph-builder.h View 1 3 chunks +37 lines, -11 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 16 chunks +117 lines, -34 lines 0 comments Download
M src/compiler/control-builders.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/control-builders.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
PTAL. Please be very thorough about style with this CL. Thanks.
5 years, 7 months ago (2015-05-27 12:08:58 UTC) #1
titzer
https://codereview.chromium.org/1158183002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1158183002/diff/1/src/compiler/ast-graph-builder.cc#newcode3233 src/compiler/ast-graph-builder.cc:3233: Node* AstGraphBuilder::TryVariableLoadDynamicGlobal( The ordering of the words is kind ...
5 years, 7 months ago (2015-05-27 14:06:22 UTC) #3
Michael Starzinger
https://codereview.chromium.org/1158183002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1158183002/diff/1/src/compiler/ast-graph-builder.cc#newcode3233 src/compiler/ast-graph-builder.cc:3233: Node* AstGraphBuilder::TryVariableLoadDynamicGlobal( On 2015/05/27 14:06:21, titzer wrote: > The ...
5 years, 7 months ago (2015-05-27 14:10:28 UTC) #4
Michael Starzinger
5 years, 6 months ago (2015-06-01 17:10:06 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698