Add ShadowRootInit dictionary.

Add ShadowRootInit dictionary.

This is a preparation for implementing "closed mode" of shadow root.

BUG=459136
TEST=fast/dom/shadow/create-shadow-root-with-parameter.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196456

[kochi, 2015-06-03 08:29:55]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-03 08:30:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158163004/1

[kochi, 2015-06-03 08:31:41]

kochi@chromium.org changed reviewers:
+ hayato@chromium.org

[kochi, 2015-06-03 08:31:41]

Hayato-san,
Could you take a look?

[hayato, 2015-06-03 08:46:12]

https://codereview.chromium.org/1158163004/diff/1/Source/core/dom/Element.idl
File Source/core/dom/Element.idl (right):

https://codereview.chromium.org/1158163004/diff/1/Source/core/dom/Element.idl...
Source/core/dom/Element.idl:67: [RaisesException, CallWith=ScriptState,
MeasureAs=ElementCreateShadowRoot] ShadowRoot createShadowRoot(optional
ShadowRootInit shadowRootInitDict);
We have to implement this feature as Runtime-Enabled feature. We can't expose
this feature yet.

Also we have to measure the usage of createShadowRoot() and
createShadowRoot(dict) separately so that we can deprecate parameterless
createShadowRoot() in the future.

[commit-bot: I haz the power, 2015-06-03 08:46:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 08:46:40]

Dry run: Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[kochi, 2015-06-03 09:11:05]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-03 09:11:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158163004/40001

[kochi, 2015-06-03 09:27:22]

On 2015/06/03 08:46:12, hayato wrote:
> https://codereview.chromium.org/1158163004/diff/1/Source/core/dom/Element.idl
> File Source/core/dom/Element.idl (right):
> 
>
https://codereview.chromium.org/1158163004/diff/1/Source/core/dom/Element.idl...
> Source/core/dom/Element.idl:67: [RaisesException, CallWith=ScriptState,
> MeasureAs=ElementCreateShadowRoot] ShadowRoot createShadowRoot(optional
> ShadowRootInit shadowRootInitDict);
> We have to implement this feature as Runtime-Enabled feature. We can't expose
> this feature yet.
> 
> Also we have to measure the usage of createShadowRoot() and
> createShadowRoot(dict) separately so that we can deprecate parameterless
> createShadowRoot() in the future.

Thanks for the review.

Added a runtime enabled feature guard so only it accepts the dictionary when
experimental flag is enabled.

For usage counting I think we still continue to use "ElementCreateShadowRoot" as
cumulative counter for both with/without parameter, and add a separate
"ElementCreateShadowRootWithParameter" for counting usage with parameter.
When the original createShadowRoot() without parameter is dropped from Blink
in the future, we can observe how the total usage increased since the beginning.

Eventually we also need counters for "open" / "closed" usages.

Please take another look.

[kochi, 2015-06-03 09:27:32]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-03 09:27:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158163004/60001

[commit-bot: I haz the power, 2015-06-03 12:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 12:38:10]

Dry run: This issue passed the CQ dry run.

[kochi, 2015-06-04 02:20:48]

Ping?

[hayato, 2015-06-04 02:25:25]

lgtm

[kochi, 2015-06-04 03:17:55]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2015-06-04 03:18:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158163004/60001

[commit-bot: I haz the power, 2015-06-04 03:25:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-04 03:25:34]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[kochi, 2015-06-04 03:29:12]

kochi@chromium.org changed reviewers:
+ tkent@chromium.org

[kochi, 2015-06-04 03:29:46]

tkent-san,

Could you review platform/RuntimeEnabledFeatures.in?

[tkent, 2015-06-04 03:38:14]

lgtm

https://codereview.chromium.org/1158163004/diff/60001/LayoutTests/fast/dom/sh...
File LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html (right):

https://codereview.chromium.org/1158163004/diff/60001/LayoutTests/fast/dom/sh...
LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html:14:
testRunner.dumpAsText();
This is unnecessary.  js-test.js does it.

[kochi, 2015-06-04 03:45:49]

Thanks for the review!

https://codereview.chromium.org/1158163004/diff/60001/LayoutTests/fast/dom/sh...
File LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html (right):

https://codereview.chromium.org/1158163004/diff/60001/LayoutTests/fast/dom/sh...
LayoutTests/fast/dom/shadow/create-shadow-root-with-parameter.html:14:
testRunner.dumpAsText();
On 2015/06/04 03:38:14, tkent wrote:
> This is unnecessary.  js-test.js does it.

Removed.

[kochi, 2015-06-04 03:49:24]

The CQ bit was checked by kochi@chromium.org

[kochi, 2015-06-04 03:49:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1158163004/#ps100001
(title: "nit fix in layout test")

[commit-bot: I haz the power, 2015-06-04 03:49:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158163004/100001

[commit-bot: I haz the power, 2015-06-04 04:54:52]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196456