Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2064)

Unified Diff: Source/devtools/front_end/elements/ElementsPanel.js

Issue 1158133004: Devtools UX: Add elements toolbar with breadcrumbs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/elements/breadcrumbs.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/elements/ElementsPanel.js
diff --git a/Source/devtools/front_end/elements/ElementsPanel.js b/Source/devtools/front_end/elements/ElementsPanel.js
index cb51eaa752a8ba0e8b30a9cadc2079d7d3dce0a8..66fb43b15d50e88b7088aeec376920e264d64e4e 100644
--- a/Source/devtools/front_end/elements/ElementsPanel.js
+++ b/Source/devtools/front_end/elements/ElementsPanel.js
@@ -48,19 +48,30 @@ WebInspector.ElementsPanel = function()
this._searchableView.setPlaceholder(WebInspector.UIString("Find by string, selector, or XPath"));
var stackElement = this._searchableView.element;
+ this._contentElement = createElement("div");
+ var crumbsContainer = createElement("div");
+ if (Runtime.experiments.isEnabled("materialDesign")) {
+ this._toolbar = this._createElementsToolbar();
+ var toolbar = stackElement.createChild("div", "elements-topbar hbox");
+ toolbar.appendChild(crumbsContainer);
+ toolbar.appendChild(this._toolbar.element);
+ stackElement.appendChild(this._contentElement);
+ } else {
+ stackElement.appendChild(this._contentElement);
+ stackElement.appendChild(crumbsContainer);
+ }
+
this._elementsPanelTreeOutilneSplit = new WebInspector.SplitWidget(false, true, "treeOutlineAnimationTimelineWidget", 300, 300);
this._elementsPanelTreeOutilneSplit.hideSidebar();
this._elementsPanelTreeOutilneSplit.setMainWidget(this._searchableView);
this._splitWidget.setMainWidget(this._elementsPanelTreeOutilneSplit);
- this._contentElement = stackElement.createChild("div");
this._contentElement.id = "elements-content";
// FIXME: crbug.com/425984
if (WebInspector.moduleSetting("domWordWrap").get())
this._contentElement.classList.add("elements-wrap");
WebInspector.moduleSetting("domWordWrap").addChangeListener(this._domWordWrapSettingChanged.bind(this));
- var crumbsContainer = stackElement.createChild("div");
crumbsContainer.id = "elements-crumbs";
this._breadcrumbs = new WebInspector.ElementsBreadcrumbs();
this._breadcrumbs.show(crumbsContainer);
@@ -109,6 +120,17 @@ WebInspector.ElementsPanel = function()
WebInspector.ElementsPanel._elementsSidebarViewTitleSymbol = Symbol("title");
WebInspector.ElementsPanel.prototype = {
+ /**
+ * @return {!WebInspector.Toolbar}
+ */
+ _createElementsToolbar: function()
+ {
+ var toolbar = new WebInspector.ExtensibleToolbar("elements-toolbar");
+ toolbar.element.classList.add("elements-toolbar");
+ toolbar.appendToolbarItem(new WebInspector.ToolbarSeparator());
+ return toolbar;
+ },
+
_loadSidebarViews: function()
{
var extensions = self.runtime.extensions("@WebInspector.Widget");
« no previous file with comments | « no previous file | Source/devtools/front_end/elements/breadcrumbs.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698