Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: runtime/observatory/tests/service/contexts_test.dart

Issue 1158103002: Use words! closureFunc -> function, closureCtxt -> context. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/contexts_test.dart
diff --git a/runtime/observatory/tests/service/contexts_test.dart b/runtime/observatory/tests/service/contexts_test.dart
index 3954d878e1985215a18f49cbb41ed63b050e9120..6bbcacde2f3353c1de9c36cd6ab5eb3d940d9ad9 100644
--- a/runtime/observatory/tests/service/contexts_test.dart
+++ b/runtime/observatory/tests/service/contexts_test.dart
@@ -55,9 +55,9 @@ var tests = [
Field field = lib.variables.singleWhere((v) => v.name == 'cleanBlock');
return field.value.load().then((Instance block) {
expect(block.isClosure, isTrue);
- expect(block.closureCtxt.isContext, isTrue);
- expect(block.closureCtxt.length, equals(0));
- return block.closureCtxt.load().then((Context ctxt) {
+ expect(block.context.isContext, isTrue);
+ expect(block.context.length, equals(0));
+ return block.context.load().then((Context ctxt) {
expect(ctxt.parentContext.isNull, isTrue);
});
});
@@ -68,9 +68,9 @@ var tests = [
Field field = lib.variables.singleWhere((v) => v.name == 'copyingBlock');
return field.value.load().then((Instance block) {
expect(block.isClosure, isTrue);
- expect(block.closureCtxt.isContext, isTrue);
- expect(block.closureCtxt.length, equals(1));
- return block.closureCtxt.load().then((Context ctxt) {
+ expect(block.context.isContext, isTrue);
+ expect(block.context.length, equals(1));
+ return block.context.load().then((Context ctxt) {
expect(ctxt.variables.single['value'].isString, isTrue);
expect(ctxt.variables.single['value'].valueAsString, equals('I could be copied into the block'));
expect(ctxt.parentContext.isContext, isTrue);
@@ -87,9 +87,9 @@ var tests = [
Field field = lib.variables.singleWhere((v) => v.name == 'fullBlock');
return field.value.load().then((Instance block) {
expect(block.isClosure, isTrue);
- expect(block.closureCtxt.isContext, isTrue);
- expect(block.closureCtxt.length, equals(1));
- return block.closureCtxt.load().then((ctxt) {
+ expect(block.context.isContext, isTrue);
+ expect(block.context.length, equals(1));
+ return block.context.load().then((ctxt) {
expect(ctxt.variables.single['value'].isInt, isTrue);
expect(ctxt.variables.single['value'].valueAsString, equals('43'));
expect(ctxt.parentContext.isContext, isTrue);
@@ -106,9 +106,9 @@ var tests = [
Field field = lib.variables.singleWhere((v) => v.name == 'fullBlockWithChain');
return field.value.load().then((Instance block) {
expect(block.isClosure, isTrue);
- expect(block.closureCtxt.isContext, isTrue);
- expect(block.closureCtxt.length, equals(1));
- return block.closureCtxt.load().then((Context ctxt) {
+ expect(block.context.isContext, isTrue);
+ expect(block.context.length, equals(1));
+ return block.context.load().then((Context ctxt) {
expect(ctxt.variables.single['value'].isInt, isTrue);
expect(ctxt.variables.single['value'].valueAsString, equals('4201'));
expect(ctxt.parentContext.isContext, isTrue);
« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698