Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1158103002: Use words! closureFunc -> function, closureCtxt -> context. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 371adbf167a72b0baa7feecb47ebef55dd404d71..c08d1716b0b1c4d3c63d6bcdf7cab19f98b1b870 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1794,8 +1794,8 @@ class Instance extends ServiceObject {
@observable int retainedSize;
@observable String valueAsString; // If primitive.
@observable bool valueAsStringIsTruncated;
- @observable ServiceFunction closureFunc; // If a closure.
- @observable Context closureCtxt; // If a closure.
+ @observable ServiceFunction function; // If a closure.
+ @observable Context context; // If a closure.
@observable String name; // If a Type.
@observable int length; // If a List.
@@ -1808,7 +1808,7 @@ class Instance extends ServiceObject {
@observable Instance key; // If a WeakProperty.
@observable Instance value; // If a WeakProperty.
- bool get isClosure => closureFunc != null;
+ bool get isClosure => function != null;
Instance._empty(ServiceObjectOwner owner) : super._empty(owner);
@@ -1821,8 +1821,8 @@ class Instance extends ServiceObject {
valueAsString = map['valueAsString'];
// Coerce absence to false.
valueAsStringIsTruncated = map['valueAsStringIsTruncated'] == true;
- closureFunc = map['closureFunc'];
- closureCtxt = map['closureCtxt'];
+ function = map['function'];
+ context = map['context'];
name = map['name'];
length = map['length'];
@@ -1845,7 +1845,7 @@ class Instance extends ServiceObject {
String get shortName {
if (isClosure) {
- return closureFunc.qualifiedName;
+ return function.qualifiedName;
}
if (valueAsString != null) {
return valueAsString;
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_view.html ('k') | runtime/observatory/tests/service/contexts_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698