content/shell/renderer/test_runner/web_test_proxy.cc - Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/web_test_proxy.cc

Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pluginfix

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/renderer/test_runner/web_test_proxy.cc

diff --git a/content/shell/renderer/test_runner/web_test_proxy.cc b/content/shell/renderer/test_runner/web_test_proxy.cc

index 27abd2b2867627b8072093678f39a86ac527dd28..0bc37a697db274de0750a61dd21a525c73d59f63 100644

--- a/content/shell/renderer/test_runner/web_test_proxy.cc

+++ b/content/shell/renderer/test_runner/web_test_proxy.cc

@@ -915,7 +915,7 @@ blink::WebPlugin* WebTestProxyBase::CreatePlugin(

const blink::WebPluginParams& params) {

if (TestPlugin::IsSupportedMimeType(params.mimeType))

return TestPlugin::create(frame, params, delegate_);

- return 0;

+ return delegate_->CreatePluginPlaceholder(frame, params);

}

void WebTestProxyBase::SetStatusText(const blink::WebString& text) {

« no previous file with comments | « content/shell/renderer/test_runner/web_test_delegate.h ('k') | no next file » | no next file with comments »