content/shell/renderer/test_runner/test_plugin_placeholder.h - Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/renderer/test_runner/test_plugin_placeholder.h

Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pluginfix

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/shell/renderer/DEPS ('k') | content/shell/renderer/test_runner/test_plugin_placeholder.cc » ('j') | content/shell/renderer/test_runner/test_plugin_placeholder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef CONTENT_SHELL_RENDERER_TEST_RUNNER_TEST_PLUGIN_PLACEHOLDER_H_

	5 #define CONTENT_SHELL_RENDERER_TEST_RUNNER_TEST_PLUGIN_PLACEHOLDER_H_

	6

	7 #include "components/plugins/renderer/plugin_placeholder.h"

	8

	9 namespace content {

	10

	11 // A subclass of PluginPlaceholder for use in Blink layout tests.

	12 class TestPluginPlaceholder : public plugins::PluginPlaceholder {

	13 public:

	14 TestPluginPlaceholder(blink::WebLocalFrame* frame,

	15 const blink::WebPluginParams& params);

	16

	17 void BindWebFrame(blink::WebFrame* frame) override {}
	tommycli 2015/05/28 21:13:34 This cannot be a no-op, as then this object isn't This cannot be a no-op, as then this object isn't collected by V8 garbage collection and leaks. It's an oversight that BindWebFrame is pure virtual in PluginPlaceholder. The two subclasses of PluginPlaceholder (LoadablePluginPlaceholder and MobileYoutubePlugin) both implement that BindWebFrame method in the exact same way. You can copy their implementations into here if you want. Otherwise, if this patch lands and sticks: https://codereview.chromium.org/1148223004/, then this class will be unnecessary. chrishtr 2015/05/28 21:16:52 Done. Show quoted text On 2015/05/28 at 21:13:34, tommycli wrote: > This cannot be a no-op, as then this object isn't collected by V8 garbage collection and leaks. > > It's an oversight that BindWebFrame is pure virtual in PluginPlaceholder. The two subclasses of PluginPlaceholder (LoadablePluginPlaceholder and MobileYoutubePlugin) both implement that BindWebFrame method in the exact same way. > > You can copy their implementations into here if you want. > > Otherwise, if this patch lands and sticks: https://codereview.chromium.org/1148223004/, then this class will be unnecessary. Done.
	18 };

	19

	20 } // namespace content

	21

	22 #endif // CONTENT_SHELL_RENDERER_TEST_RUNNER_TEST_PLUGIN_PLACEHOLDER_H_

OLD	NEW