components/plugins/renderer/test_plugin_placeholder.h - Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/plugins/renderer/test_plugin_placeholder.h

Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pluginfix

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/plugins.gypi ('K') | « components/plugins/renderer/plugin_placeholder.cc ('k') | components/plugins/renderer/test_plugin_placeholder.cc » ('j') | components/plugins/renderer/test_plugin_placeholder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_PLUGINS_RENDERER_TEST_PLUGIN_PLACEHOLDER_H_

	6 #define COMPONENTS_PLUGINS_RENDERER_TEST_PLUGIN_PLACEHOLDER_H_

	7

	8 #include "components/plugins/renderer/plugin_placeholder.h"

	9

	10 namespace plugins {

	11

	12 // A subclass of PluginPlaceholder for use in Blink layout tests.

	13
	tommycli 2015/05/26 20:08:18 No need for blank line here No need for blank line here chrishtr 2015/05/28 20:13:56 Done. Show quoted text On 2015/05/26 at 20:08:18, tommycli wrote: > No need for blank line here Done.
	14 class TestPluginPlaceholder : public PluginPlaceholder {

	15 public:
	tommycli 2015/05/26 20:08:18 formatting doesn't look right here. maybe git cl f formatting doesn't look right here. maybe git cl format? chrishtr 2015/05/28 20:13:56 Ran git cl format. Show quoted text On 2015/05/26 at 20:08:18, tommycli wrote: > formatting doesn't look right here. maybe git cl format? Ran git cl format.
	16 TestPluginPlaceholder(blink::WebLocalFrame* frame,

	17 const blink::WebPluginParams& params);

	18 };

	19

	20 } // namespace plugins

	21

	22 #endif // COMPONENTS_PLUGINS_RENDERER_TEST_PLUGIN_PLACEHOLDER_H_

OLD	NEW