components/plugins/renderer/test_plugin_placeholder.cc - Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/plugins/renderer/test_plugin_placeholder.cc

Issue 1158063002: Add plugins::TestPluginPlaceholder class and allow its use in Blink layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pluginfix

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/plugins/renderer/test_plugin_placeholder.h"

	6

	7 namespace plugins {

	8

	9 TestPluginPlaceholder::TestPluginPlaceholder(

	10 blink::WebLocalFrame* frame, const blink::WebPluginParams& params)

	11 : PluginPlaceholder(nullptr, frame, params, "<div>Test content</div>")
	tommycli 2015/05/26 20:08:18 Can we just eliminate this class entirely? Why not Can we just eliminate this class entirely? Why not just create a PluginPlaceholder with the <div>Test content</div> html_data in your test code? chrishtr 2015/05/26 20:52:36 The reason is that someone has to include the stri Show quoted text On 2015/05/26 at 20:08:18, tommycli wrote: > Can we just eliminate this class entirely? Why not just create a PluginPlaceholder with the <div>Test content</div> html_data in your test code? The reason is that someone has to include the string of HTML. Maybe I can extract that from the child nodes of the containing <embed> tag, will try that. It would be great for the layout test to easily specify plugin webview content itself. tommycli 2015/05/26 21:18:02 Perhaps I am misunderstanding something. Can "<div Show quoted text On 2015/05/26 20:52:36, chrishtr wrote: > On 2015/05/26 at 20:08:18, tommycli wrote: > > Can we just eliminate this class entirely? Why not just create a > PluginPlaceholder with the <div>Test content</div> html_data in your test code? > > The reason is that someone has to include the string of HTML. Maybe I can > extract that from the child nodes of the containing <embed> tag, will try that. > It would be great for the layout test to easily specify plugin webview content > itself. Perhaps I am misunderstanding something. Can "<div>Test content</div>" just be a string literal within web_test_proxy.cc?
	12 { }

	13

	14 } // namespace plugins

OLD	NEW