chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java - Issue 1158053005: Android: Store language .pak files in res/raw rather than assets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

Issue 1158053005: Android: Store language .pak files in res/raw rather than assets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk-v8

Patch Set: rebased Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/gyp/locale_pak_resources.py ('K') | « chrome/chrome_android_paks.gypi ('k') | components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

index 903609f4733dd89627a7852ca59211f6ffb1d79a..a9b0c6fc256664b9daecd451e73a2dbbd1103c8d 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

@@ -37,7 +37,7 @@ public class CastApplication extends ContentApplication {

}

public static void initializeApplicationParameters(Context context) {

- ResourceExtractor.setMandatoryPaksToExtract(MANDATORY_PAK_FILES);

+ ResourceExtractor.setMandatoryPaksToExtract(0, MANDATORY_PAK_FILES);

Yaron 2015/06/16 03:50:45 The passing 0 for most of these is kinda ugly but

agrieve 2015/06/16 15:47:42 Yeah, no worse than passing "" IMO. Do plan to mak

PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX, context);

}