Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1158053003: kill IPDF_DocParser(). (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

kill IPDF_DocParser(). Its fine to program to interfaces, but since the sole concrete implementation is in the same header as the interface, the code is bypassing it anyways. We can de-virtualize some things along the way, and remove two non-existent function prototypes from one of the headers. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e06b686620286dfe604693e12e70a4077625eae5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Explicit constructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -60 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 4 chunks +11 lines, -9 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 1 5 chunks +24 lines, -47 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Lei, for review.
5 years, 6 months ago (2015-06-02 21:06:37 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/1158053003/diff/1/core/include/fpdfapi/fpdf_parser.h File core/include/fpdfapi/fpdf_parser.h (right): https://codereview.chromium.org/1158053003/diff/1/core/include/fpdfapi/fpdf_parser.h#newcode64 core/include/fpdfapi/fpdf_parser.h:64: CPDF_Document(CPDF_Parser* pParser); explicit
5 years, 6 months ago (2015-06-02 21:15:23 UTC) #2
Tom Sepez
https://codereview.chromium.org/1158053003/diff/1/core/include/fpdfapi/fpdf_parser.h File core/include/fpdfapi/fpdf_parser.h (right): https://codereview.chromium.org/1158053003/diff/1/core/include/fpdfapi/fpdf_parser.h#newcode64 core/include/fpdfapi/fpdf_parser.h:64: CPDF_Document(CPDF_Parser* pParser); On 2015/06/02 21:15:23, Lei Zhang wrote: > ...
5 years, 6 months ago (2015-06-02 21:18:42 UTC) #3
Tom Sepez
5 years, 6 months ago (2015-06-02 21:19:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e06b686620286dfe604693e12e70a4077625eae5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698