Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1158043004: Prevent SSL certificate export from jamming the chrome. (Closed)

Created:
5 years, 6 months ago by benwells
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang, ananta, scottmg
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent SSL certificate export from jamming the chrome. Fix a bug where exiting the SSL certificate export from the page info bubble (connection \ certificate information \ details \ save to file) could cause chrome to hang on Windows 8.1. BUG=344012 Committed: https://crrev.com/069a431548642cd3de75bc4cd07787ef13e6c0cb Cr-Commit-Position: refs/heads/master@{#333639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/views/certificate_viewer_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
benwells
Scott, does this look reasonable?
5 years, 6 months ago (2015-06-01 04:22:39 UTC) #2
benwells
On 2015/06/01 04:22:39, benwells wrote: > Scott, does this look reasonable? BTW, it might make ...
5 years, 6 months ago (2015-06-01 04:24:12 UTC) #3
scottmg
I'm not familiar with that part of MessageLoop. Ananta has been looking into the PeekMessage ...
5 years, 6 months ago (2015-06-01 16:07:18 UTC) #5
benwells
On 2015/06/01 16:07:18, scottmg wrote: > I'm not familiar with that part of MessageLoop. Ananta ...
5 years, 6 months ago (2015-06-03 04:21:23 UTC) #6
ananta
lgtm
5 years, 6 months ago (2015-06-05 20:12:21 UTC) #7
benwells
+thestig for owners review
5 years, 6 months ago (2015-06-09 23:35:39 UTC) #9
Lei Zhang
rs lgtm
5 years, 6 months ago (2015-06-09 23:43:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158043004/1
5 years, 6 months ago (2015-06-10 00:17:19 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 01:28:14 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 01:29:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/069a431548642cd3de75bc4cd07787ef13e6c0cb
Cr-Commit-Position: refs/heads/master@{#333639}

Powered by Google App Engine
This is Rietveld 408576698