Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1158043003: Remove most svn related testing. (Closed)

Created:
5 years, 7 months ago by M-A Ruel
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove most svn related testing. Subversion usage is going away, tests get the kick first. R=iannucci@chromium.org BUG=475320 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295411

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo in doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3251 lines) Patch
M testing_support/fake_repos.py View 1 13 chunks +7 lines, -363 lines 0 comments Download
M testing_support/local_rietveld.py View 1 chunk +0 lines, -5 lines 0 comments Download
M testing_support/super_mox.py View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/checkout_test.py View 5 chunks +0 lines, -409 lines 0 comments Download
D tests/gcl_unittest.py View 1 chunk +0 lines, -622 lines 0 comments Download
M tests/gclient_scm_test.py View 1 chunk +0 lines, -684 lines 0 comments Download
M tests/gclient_smoketest.py View 5 chunks +6 lines, -876 lines 0 comments Download
M tests/scm_unittest.py View 1 chunk +0 lines, -287 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
M-A Ruel
Remaining tests still run. It could break external users using subversion support in fake_repos.py. We'll ...
5 years, 7 months ago (2015-05-26 18:24:40 UTC) #1
iannucci
Woohoo! Lgtm! https://codereview.chromium.org/1158043003/diff/1/testing_support/fake_repos.py File testing_support/fake_repos.py (right): https://codereview.chromium.org/1158043003/diff/1/testing_support/fake_repos.py#newcode135 testing_support/fake_repos.py:135: """Generategit repositories to test gclient functionality. typo
5 years, 7 months ago (2015-05-26 18:36:43 UTC) #3
M-A Ruel
https://codereview.chromium.org/1158043003/diff/1/testing_support/fake_repos.py File testing_support/fake_repos.py (right): https://codereview.chromium.org/1158043003/diff/1/testing_support/fake_repos.py#newcode135 testing_support/fake_repos.py:135: """Generategit repositories to test gclient functionality. On 2015/05/26 18:36:43, ...
5 years, 7 months ago (2015-05-26 19:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158043003/20001
5 years, 7 months ago (2015-05-26 19:16:22 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 19:22:07 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295411

Powered by Google App Engine
This is Rietveld 408576698