[CrNet] Properly setup net log.

[CrNet] Properly setup net log.

BUG=493250
Committed: https://crrev.com/5abcbb9029d13faff9d2a2fb327a23ab286fdba9
Cr-Commit-Position: refs/heads/master@{#333115}

[mef, 2015-06-05 16:15:09]

mef@chromium.org changed reviewers:
+ ellyjones@chromium.org, mmenke@chromium.org

[mef, 2015-06-05 16:15:11]

PTAL.

[mmenke, 2015-06-05 18:56:49]

LGTM

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment.mm
File ios/crnet/crnet_environment.mm (right):

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment...
ios/crnet/crnet_environment.mm:174: DCHECK(net_log_.get());
nit:  get not needed.

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment...
ios/crnet/crnet_environment.mm:176: if (net_log_observer_.get())
nit:  get not needed.

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment...
ios/crnet/crnet_environment.mm:188: scoped_ptr<base::Value>
constants(net::GetNetConstants().Pass());
This isn't needed - can just pass in a null pointer and it will automatically
get the default set of net constants.

[mef, 2015-06-05 19:52:06]

Thanks!

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment.mm
File ios/crnet/crnet_environment.mm (right):

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment...
ios/crnet/crnet_environment.mm:174: DCHECK(net_log_.get());
On 2015/06/05 18:56:49, mmenke wrote:
> nit:  get not needed.

Done.

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment...
ios/crnet/crnet_environment.mm:176: if (net_log_observer_.get())
On 2015/06/05 18:56:49, mmenke wrote:
> nit:  get not needed.

Done.

https://codereview.chromium.org/1158033010/diff/1/ios/crnet/crnet_environment...
ios/crnet/crnet_environment.mm:188: scoped_ptr<base::Value>
constants(net::GetNetConstants().Pass());
On 2015/06/05 18:56:49, mmenke wrote:
> This isn't needed - can just pass in a null pointer and it will automatically
> get the default set of net constants.

Done.

[mef, 2015-06-05 19:54:25]

The CQ bit was checked by mef@chromium.org

[mef, 2015-06-05 19:54:25]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1158033010/#ps40001
(title: "Remove unneeded get()")

[commit-bot: I haz the power, 2015-06-05 19:54:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1158033010/40001

[commit-bot: I haz the power, 2015-06-05 20:08:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 20:10:50]

Patchset 3 (id:??) landed as
https://crrev.com/5abcbb9029d13faff9d2a2fb327a23ab286fdba9
Cr-Commit-Position: refs/heads/master@{#333115}