Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1158033007: Fix flaky fast/events/touch/compositor-touch-hit-rects-scroll.html (Closed)

Created:
4 years, 11 months ago by Yufeng Shen (Slow to review)
Modified:
4 years, 10 months ago
Reviewers:
miletus1, Rick Byers
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix flaky fast/events/touch/compositor-touch-hit-rects-scroll.html 1. We expect children of overflow div to be part of scrollingContent layer to mark it as "scrolling" in the expected output. And also expect the hit-test rect to be relative to the scrollingContent layer to make the visualization correct. There is case where the scrolling element lives in a separate GraphicsLayer than the scrollingContent layer and mark scrollingCotent layer as its scroll parent. We want to detect this case and also mark the element as "scrolling" in the test output. And we also adjust the hit-test rect to be relative to the scrollingContent layer to make the visualization to work. 2. Because there is a div with negative z-index in the page, compositor forms a new layer "LayoutBlockFlow HTML" which, instead of the root document layer, becomes the parent of all the test divs. So we see that overflowwithborder has a hit-test rect in the space of "HTML", instead of "#document". We just need to rebaseline for this. BUG=339118 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
miletus1
4 years, 11 months ago (2015-05-29 16:03:32 UTC) #3
Rick Byers
Whoa, just realized I totally missed this review - sorry! LGTM
4 years, 10 months ago (2015-06-11 03:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158033007/1
4 years, 10 months ago (2015-06-11 03:35:26 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 05:51:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196914

Powered by Google App Engine
This is Rietveld 408576698