Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1158033006: Track if textLength spacing is in effect while walking the line box tree (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Track if textLength spacing is in effect while walking the line box tree Instead of calling parentDefinesTextLength() in layoutTextOnLineOrPath(), keep a flag updated as we traverse the line box tree. This eliminates the walk up the ancestor-chain, but more importantly it avoids checking this for each text box. To make this easier, layoutCharactersInTextBoxes() is moved from SVGRootInlineBox to SVGTextLayoutEngine. This allows simplifying SVGTextLayoutEngine::beginTextPathLayout a bit to make it more independent. Gives roughly a 1% speedup on separate-x.svg from the bug, when run through PerfTestRunner.measurePageLoadTime. BUG=486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -66 lines) Patch
M Source/core/layout/svg/SVGTextLayoutEngine.h View 4 chunks +9 lines, -6 lines 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 6 chunks +46 lines, -27 lines 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGRootInlineBox.cpp View 2 chunks +1 line, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
A few more cycles bites the dust.
5 years, 6 months ago (2015-05-29 15:49:36 UTC) #2
pdr.
LGTM
5 years, 6 months ago (2015-05-29 16:12:49 UTC) #3
f(malita)
lgtm
5 years, 6 months ago (2015-05-29 16:26:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158033006/1
5 years, 6 months ago (2015-05-29 16:27:23 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 16:30:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196158

Powered by Google App Engine
This is Rietveld 408576698