Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: net/base/net_util_icu.cc

Issue 1158023004: Added characters that look like padlocks to net IDN character blacklist. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Blacklist the other padlock symbols, and more/fixed tests. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/net_util_icu_unittest.cc » ('j') | net/base/net_util_icu_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util_icu.cc
diff --git a/net/base/net_util_icu.cc b/net/base/net_util_icu.cc
index 94e1a0d7232a65a7c517e714fa128fc571b47aa2..e32f813b2bc7de1a1ac301bc3ca17e88de08f5b9 100644
--- a/net/base/net_util_icu.cc
+++ b/net/base/net_util_icu.cc
@@ -202,7 +202,8 @@ bool IsIDNComponentSafe(const base::char16* str,
L"\u29f6\u29f8\u2afb\u2afd][\u2ff0-\u2ffb][\u3014"
L"\u3015\u3033\u3164\u321d\u321e\u33ae\u33af\u33c6\u33df\ufe14"
L"\ufe15\ufe3f\ufe5d\ufe5e\ufeff\uff0e\uff06\uff61\uffa0\ufff9]"
- L"[\ufffa-\ufffd]]"), status);
+ L"[\ufffa-\ufffd]\ud83d\udd0f\ud83d\udd10\ud83d\udd12\ud83d\udd13]"),
+ status);
mmenke 2015/06/05 15:08:06 status is indented strangely here - should just li
Matt Giuca 2015/06/09 04:10:34 Lining up with the previous L is incorrect (it wou
DCHECK(U_SUCCESS(status));
icu::RegexMatcher dangerous_patterns(icu::UnicodeString(
// Lone katakana no, so, or n
@@ -219,7 +220,8 @@ bool IsIDNComponentSafe(const base::char16* str,
"\\u29f6\\u29f8\\u2afb\\u2afd][\\u2ff0-\\u2ffb][\\u3014"
"\\u3015\\u3033\\u3164\\u321d\\u321e\\u33ae\\u33af\\u33c6\\u33df\\ufe14"
"\\ufe15\\ufe3f\\ufe5d\\ufe5e\\ufeff\\uff0e\\uff06\\uff61\\uffa0\\ufff9]"
- "[\\ufffa-\\ufffd]]", -1, US_INV), status);
+ "[\\ufffa-\\ufffd]\\ud83d\\udd0f\\ud83d\\udd10\\ud83d\\udd12"
+ "\\ud83d\\udd13]", -1, US_INV), status);
DCHECK(U_SUCCESS(status));
icu::RegexMatcher dangerous_patterns(icu::UnicodeString(
// Lone katakana no, so, or n
« no previous file with comments | « no previous file | net/base/net_util_icu_unittest.cc » ('j') | net/base/net_util_icu_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698