Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1158023003: Mark proxy map as unstable during fixing freezing, sealing or preventing extensions). (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark proxy map as unstable during proxy fixing (freezing, sealing or preventing extensions). BUG=chromium:493568 LOG=N Committed: https://crrev.com/65ada9fa0b0d938c2e05cbee08a8a7f47665db87 Cr-Commit-Position: refs/heads/master@{#28759}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M src/factory.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M src/objects.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-493568.js View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Igor Sheludko
PTALCQ
5 years, 6 months ago (2015-05-29 13:48:48 UTC) #2
Toon Verwaest
https://codereview.chromium.org/1158023003/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/1158023003/diff/1/src/factory.cc#newcode1989 src/factory.cc:1989: map->mark_unstable(); Why not make it unstable in those places?
5 years, 6 months ago (2015-05-29 14:12:52 UTC) #3
Igor Sheludko
Addressed comments
5 years, 6 months ago (2015-05-29 18:18:07 UTC) #4
Toon Verwaest
lgtm
5 years, 6 months ago (2015-06-02 10:50:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1158023003/20001
5 years, 6 months ago (2015-06-02 10:54:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 11:29:26 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 11:29:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65ada9fa0b0d938c2e05cbee08a8a7f47665db87
Cr-Commit-Position: refs/heads/master@{#28759}

Powered by Google App Engine
This is Rietveld 408576698