Issue 1157993010: Add --sky support in mojo_shell.py.

Issue 1157993010: Add --sky support in mojo_shell.py. (Closed)

Created:
5 years, 6 months ago by ppi

Modified:
5 years, 6 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add --sky support in mojo_shell.py. Pass --sky SKY_FILE to run Sky in mojo_shell. E.g. mojo/tools/mojo_shell.py --sky sky/examples/stocks/main.sky R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/875296552fa5f1d2d79da9d520d2ea597a592e9b

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Don't rely on content-type. #

Patch Set 4 : Fix the port for Sky packages. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	mojo/tools/mojo_shell.py	View	1 2 3	4 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

qsr

https://codereview.chromium.org/1157993010/diff/20001/mojo/tools/mojo_shell.py File mojo/tools/mojo_shell.py (right): https://codereview.chromium.org/1157993010/diff/20001/mojo/tools/mojo_shell.py#newcode64 mojo/tools/mojo_shell.py:64: parser.add_argument('--sky', This is not only sky. This is for ...

5 years, 6 months ago (2015-06-08 15:18:52 UTC) #2

ppi

5 years, 6 months ago (2015-06-08 15:29:14 UTC) #3

ppi

5 years, 6 months ago (2015-06-08 15:50:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
875296552fa5f1d2d79da9d520d2ea597a592e9b (presubmit successful).

Expand Messages | Collapse Messages