Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 1157993006: Revert of Update sizes expectations since static linking ffmpeg. (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update sizes expectations since static linking ffmpeg. (patchset #1 id:1 of https://codereview.chromium.org/1161633003/) Reason for revert: r332994 reverted the static linking ffmpeg CL and the size expectations is now red due to "improvement". Original issue's description: > Update sizes expectations since static linking ffmpeg. > > This updates bss sizes for the following: > - linux-release-64/sizes/chrome-bss/bss > - linux-release/sizes/chrome-bss/bss > - mac-release/sizes/ChromiumFramework/ChromiumFramework > - xp-release/sizes/chrome_child.dll/chrome_child.dll > > Change https://codereview.chromium.org/1141703002/ causes ffmpeg > to be statically linked into chrome (or chrome_child on windows). > > While chrome/chrome_child have grown significantly, the net change > (now that ffmpegsumo.dll is gone) is actually a savings of a few > hundred KB due to dead code elimination in static linking. > > (Bugs motivating the original static linking change) > BUG=435455, 429131, 441908 > > Committed: https://crrev.com/41c1b31dc7983a1dca627f9e00ee3977b75e5b6f > Cr-Commit-Position: refs/heads/master@{#332938} TBR=mkwst@chromium.org,zea@chromium.org,calamity@chromium.org,dalecurtis@chromium.org,chcunningham@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=435455, 429131, 441908 Committed: https://crrev.com/0ef24d4197503e228606a4523022d9e9f918202f Cr-Commit-Position: refs/heads/master@{#333000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/perf_expectations/perf_expectations.json View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Update sizes expectations since static linking ffmpeg.
5 years, 6 months ago (2015-06-05 03:04:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157993006/1
5 years, 6 months ago (2015-06-05 03:05:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 03:06:36 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 03:07:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ef24d4197503e228606a4523022d9e9f918202f
Cr-Commit-Position: refs/heads/master@{#333000}

Powered by Google App Engine
This is Rietveld 408576698