Issue 1157993005: Give RenderObject a useful toString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157993005: Give RenderObject a useful toString(). (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Give RenderObject a useful toString(). This makes debugging the render tree a lot easier. Just print the node you care about, and you get an indented tree view of its subtree, including settings. New subclasses should implement the new virtual method debugDescribeSettings() to expose new settings. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f2326b33aa651853671a7893c088631e9466c310

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	sky/sdk/lib/framework/components2/scaffold.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	6 chunks	+19 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/flex.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/object.dart	View	4 chunks	+28 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/paragraph.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-04 21:10:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f2326b33aa651853671a7893c088631e9466c310 (presubmit successful).