Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1157993002: Correctly hook up materialized receiver into the evaluation context chain. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev, Yang, lushnikov, kozy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly hook up materialized receiver into the evaluation context chain. R=ulan@chromium.org BUG=chromium:491943 LOG=Y Committed: https://crrev.com/0837b437209d68a87b1a55e7b7e8b982d8b61a31 Cr-Commit-Position: refs/heads/master@{#28628}

Patch Set 1 #

Patch Set 2 : blacklist from turbofan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M src/runtime/runtime-debug.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-491943.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Yang
5 years, 7 months ago (2015-05-26 12:13:46 UTC) #1
Yang
Andy, you can count yourself lucky that I didn't revert your CL again ;)
5 years, 7 months ago (2015-05-26 12:15:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157993002/1
5 years, 7 months ago (2015-05-26 12:15:51 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2963)
5 years, 7 months ago (2015-05-26 12:18:13 UTC) #6
ulan
lgtm
5 years, 7 months ago (2015-05-26 12:22:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157993002/20001
5 years, 7 months ago (2015-05-26 12:37:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 13:06:41 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0837b437209d68a87b1a55e7b7e8b982d8b61a31 Cr-Commit-Position: refs/heads/master@{#28628}
5 years, 7 months ago (2015-05-26 13:06:50 UTC) #12
wingo
5 years, 6 months ago (2015-06-08 12:09:20 UTC) #13
Message was sent while issue was closed.
On 2015/05/26 12:15:31, Yang wrote:
> Andy, you can count yourself lucky that I didn't revert your CL again ;)

Wow, thank you Yang.  Coming back from a trip I was a bit terrified to see what
had happened here; a relief to see that it stuck.

Powered by Google App Engine
This is Rietveld 408576698