Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1157943007: Disable unused attributes when using copy shader (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable unused attributes when using copy shader BUG=chromium:496540 Committed: https://skia.googlesource.com/skia/+/d624634aff330485dc56fc09773cc6d4ec092c4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
5 years, 6 months ago (2015-06-04 16:51:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157943007/1
5 years, 6 months ago (2015-06-04 16:52:16 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-04 16:52:18 UTC) #5
joshualitt
LGTM, probably not worth only doing this if we're in chromium.
5 years, 6 months ago (2015-06-04 16:59:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_TIMED_OUT, no build URL)
5 years, 6 months ago (2015-06-04 18:52:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157943007/1
5 years, 6 months ago (2015-06-04 19:18:06 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 20:57:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d624634aff330485dc56fc09773cc6d4ec092c4d

Powered by Google App Engine
This is Rietveld 408576698