Index: cc/raster/one_copy_tile_task_worker_pool.h |
diff --git a/cc/raster/one_copy_tile_task_worker_pool.h b/cc/raster/one_copy_tile_task_worker_pool.h |
index a808fc8828dff45f2e403690df1ad8685340641a..4f19467e09197066c89dd4cdcd39d37df42f8c3d 100644 |
--- a/cc/raster/one_copy_tile_task_worker_pool.h |
+++ b/cc/raster/one_copy_tile_task_worker_pool.h |
@@ -62,7 +62,7 @@ class CC_EXPORT OneCopyTileTaskWorkerPool : public TileTaskWorkerPool, |
// Playback raster source and schedule copy of |raster_resource| resource to |
// |output_resource|. Returns a non-zero sequence number for this copy |
// operation. |
- CopySequenceNumber PlaybackAndScheduleCopyOnWorkerThread( |
+ void PlaybackAndCopyOnWorkerThread( |
reveman
2015/06/09 13:30:55
Is this function needed? Can't RasterBuffer::Playb
sohanjg
2015/06/09 15:59:24
Hmm..except for max_bytes_per_copy_operation_ we c
reveman
2015/06/09 18:00:30
Let's keep PlaybackAndCopyOnWorkerThread until the
sohanjg
2015/06/11 13:32:26
Acknowledged.
|
bool reusing_raster_resource, |
scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> |
raster_resource_write_lock, |
@@ -109,7 +109,7 @@ class CC_EXPORT OneCopyTileTaskWorkerPool : public TileTaskWorkerPool, |
void OnTaskSetFinished(TaskSet task_set); |
void AdvanceLastFlushedCopyTo(CopySequenceNumber sequence); |
reveman
2015/06/09 13:30:56
is this used?
sohanjg
2015/06/09 15:59:24
Done.
|
- void IssueCopyOperations(int64 count); |
+ void IssueCopyOperations(CopyOperation* op); |
void ScheduleCheckForCompletedCopyOperationsWithLockAcquired( |
reveman
2015/06/09 13:30:55
used?
sohanjg
2015/06/09 15:59:24
Done.
|
bool wait_if_needed); |
void CheckForCompletedCopyOperations(bool wait_if_needed); |
reveman
2015/06/09 13:30:55
used?
sohanjg
2015/06/09 15:59:24
Done.
|
@@ -129,8 +129,6 @@ class CC_EXPORT OneCopyTileTaskWorkerPool : public TileTaskWorkerPool, |
const bool have_persistent_gpu_memory_buffers_; |
TaskSetCollection tasks_pending_; |
scoped_refptr<TileTask> task_set_finished_tasks_[kNumberOfTaskSets]; |
- CopySequenceNumber last_issued_copy_operation_; |
- CopySequenceNumber last_flushed_copy_operation_; |
// Task graph used when scheduling tasks and vector used to gather |
// completed tasks. |
@@ -139,12 +137,7 @@ class CC_EXPORT OneCopyTileTaskWorkerPool : public TileTaskWorkerPool, |
base::Lock lock_; |
reveman
2015/06/09 13:30:56
why do we still need this?
sohanjg
2015/06/09 15:59:24
we will need it, to get GpuMemoryBuffer right ? in
reveman
2015/06/09 18:00:30
GpuMemoryBuffer allocation is thread safe so you d
|
// |lock_| must be acquired when accessing the following members. |
- base::ConditionVariable copy_operation_count_cv_; |
- int bytes_scheduled_since_last_flush_; |
- size_t issued_copy_operation_count_; |
CopyOperation::Deque pending_copy_operations_; |
reveman
2015/06/09 13:30:56
used?
sohanjg
2015/06/09 15:59:24
Done.
|
- CopySequenceNumber next_copy_operation_sequence_; |
- bool check_for_completed_copy_operations_pending_; |
base::TimeTicks last_check_for_completed_copy_operations_time_; |
reveman
2015/06/09 13:30:56
used?
sohanjg
2015/06/09 15:59:24
Done.
|
bool shutdown_; |